Conversation

mohanli-ml

In #770 we make the client to attempt DirectPath by default using the default spanner endpoint spanner.googleapis.com. However, currently DirectPath tests still need to use a custom endpoint aa423245250f2bbf.sandbox.googleapis.com, so we need to set it to a customChannelProvider, which will override the defaultChannelProvider in https://.com/googleapis/java-spanner/blob/master/google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpc.java#L336. As a result, DirectPath tests can not be run properly. This PR fixes this problem by setting up the customChannelProvider properly.

@mohanli-mlmohanli-ml requested a review from a team as a code owner January 7, 2021 02:51
@product-auto-labelproduct-auto-label bot added the api: spannerIssues related to the googleapis/java-spanner API.label Jan 7, 2021
@google-clagoogle-cla bot added the cla: yesThis human has signed the Contributor License Agreement.label Jan 7, 2021
@codecov

Codecov Report

Merging #780 (b750278) into master (beeac09) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #780      +/-   ##
============================================
+ Coverage     85.01%   85.05%   +0.04%     
- Complexity     2561     2564       +3     
============================================
  Files           143      143              
  Lines         14005    14005              
  Branches       1337     1337              
============================================
+ Hits          11906    11912       +6     
+ Misses         1537     1532       -5     
+ Partials        562      561       -1     
Impacted FilesCoverage ΔComplexity Δ
.../google/cloud/spanner/SpannerExceptionFactory.java83.50% <0.00%> (+1.03%)47.00% <0.00%> (+1.00%)
...m/google/cloud/spanner/connection/FailedQuery.java82.75% <0.00%> (+6.89%)3.00% <0.00%> (+1.00%)
...r/AbortedDueToConcurrentModificationException.java85.71% <0.00%> (+42.85%)2.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beeac09...b750278. Read the comment docs.

@thiagotnunesthiagotnunes merged commit 9b94c6e into googleapis:master Jan 7, 2021
thiagotnunes pushed a commit that referenced this pull request May 6, 2021
* chore: add DirectPath fallback integration test

* fix: Set up DirectPath e2e tests correctly
ansh0l pushed a commit to ansh0l/java-spanner that referenced this pull request Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by
cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will
update the corresponding PR to depend on the newer version of go-genproto, and
assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot
will not create any more regeneration PRs. If all regen PRs are closed,
gapicgen will create a new set of regeneration PRs once per night.

If you have been assigned to review this PR, please:

- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship. That will prompt
genbot to assign reviewers to the google-cloud-go PR.

Corresponding google-cloud-go PR: googleapis/google-cloud-go#5785

Changes:

chore(documentai): remove unused imports
  PiperOrigin-RevId: 436716640
  Source-Link: googleapis/googleapis@ab8c7d2

chore(osconfig/agentendpoint): remove unused imports
  PiperOrigin-RevId: 436511258
  Source-Link: googleapis/googleapis@34b98de

chore: regenerate API index

  Source-Link: googleapis/googleapis@feefce3

feat: promote v1beta2 features to v1
  PiperOrigin-RevId: 436510287
  Source-Link: googleapis/googleapis@4008372

docs: fix relative and broken links
  PiperOrigin-RevId: 436501833
  Source-Link: googleapis/googleapis@42efaa7

chore(certificatemanager): Configure Ruby builds for cloudoptimization and certificatemanager
  PiperOrigin-RevId: 436334879
  Source-Link: googleapis/googleapis@4779e9f

docs(dialogflow/cx): improved docs format
  PiperOrigin-RevId: 436315342
  Source-Link: googleapis/googleapis@321e5e4

chore: regenerate API index

  Source-Link: googleapis/googleapis@f6d7ccb

feat(metastore): Added DatabaseType field for the type of backing store used feat: Added AVRO DatabaseDumpSpec for importing and exporting Avro files feat: Added additional endTime field for MetadataImports feat: Added RESTORING status on Backups feat: Added support to record the services that are restoring the backup feat: Added configuration for Dataplex integration feat: Added support for IAM management for metadata resources feat: Added AuxiliaryVersionConfig for configuring the auxiliary hive versions during creation or update of the DPMS instance feat: Added NetworkConfig for exposing the DPMS endpoint in multiple subnetworks using PSC (this skips the need for VPC peering) feat: Added EncryptionConfig which contains information used to configure the Dataproc Metastore service to encrypt customer data at rest (CMEK) docs: formatting improvements
  PiperOrigin-RevId: 436271267
  Source-Link: googleapis/googleapis@463caca

chore: regenerate API index

  Source-Link: googleapis/googleapis@22e0fa0

Synchronize new proto/yaml changes.
  PiperOrigin-RevId: 436114471
  Source-Link: googleapis/googleapis@6379d5f

docs(dialogflow): added explanation for SuggestionResult
  PiperOrigin-RevId: 435670355
  Source-Link: googleapis/googleapis@5d85995

chore: regenerate API index

  Source-Link: googleapis/googleapis@1605e8d

feat: added HUMAN_INTERVENTION_NEEDED type in ConversationEvent feat: added SetSuggestionFeatureConfig and ClearSuggestionFeatureConfig apis feat: added AGENT_FACING_SMART_REPLY type in KnowledgeType feat: added GcsDestination. docs: added explanation for uri fields in resources docs: added explanation for SuggestionResult docs: added explanation for language code in session
  PiperOrigin-RevId: 435479473
  Source-Link: googleapis/googleapis@d9ca515

docs(dialogflow/cx): added explanation for uri fields in resources docs: improved docs format
  PiperOrigin-RevId: 435479428
  Source-Link: googleapis/googleapis@4dd75c2

docs(talent): Added functionality in the companyDisplayNames filter to support fuzzy matching
  PiperOrigin-RevId: 435467010
  Source-Link: googleapis/googleapis@cb38285

docs: fixed a broken documentation link
  PiperOrigin-RevId: 435466293
  Source-Link: googleapis/googleapis@1b146e7
Sign up for free to join this conversation on . Already have an account? Sign in to comment
api: spannerIssues related to the googleapis/java-spanner API.cla: yesThis human has signed the Contributor License Agreement.
None yet

Successfully merging this pull request may close these issues.