Conversation

olavloite

Allows min/max sessions for the backing SessionPool to be specified in the connection URL.

Towards googleapis/java-spanner-jdbc#334

@olavloiteolavloite requested a review from a team as a code owner January 26, 2021 15:58
@google-clagoogle-cla bot added the cla: yesThis human has signed the Contributor License Agreement.label Jan 26, 2021
@product-auto-labelproduct-auto-label bot added the api: spannerIssues related to the googleapis/java-spanner API.label Jan 26, 2021
@codecov

Codecov Report

Merging #821 (4bdabb6) into master (2f1450c) will decrease coverage by 0.07%.
The diff coverage is 59.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #821      +/-   ##
============================================
- Coverage     85.05%   84.98%   -0.08%     
- Complexity     2564     2580      +16     
============================================
  Files           143      143              
  Lines         14062    14132      +70     
  Branches       1348     1368      +20     
============================================
+ Hits          11961    12010      +49     
- Misses         1539     1550      +11     
- Partials        562      572      +10     
Impacted FilesCoverage ΔComplexity Δ
...a/com/google/cloud/spanner/SessionPoolOptions.java70.31% <30.95%> (-19.35%)19.00 <3.00> (+3.00)⬇️
...le/cloud/spanner/connection/ConnectionOptions.java89.13% <88.57%> (+1.87%)77.00 <8.00> (+12.00)
...m/google/cloud/spanner/connection/SpannerPool.java86.88% <100.00%> (+2.44%)31.00 <0.00> (ø)
...ain/java/com/google/cloud/spanner/SessionPool.java89.24% <0.00%> (+0.19%)73.00% <0.00%> (ø%)
...n/java/com/google/cloud/spanner/SessionClient.java92.06% <0.00%> (+0.79%)16.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f1450c...075683c. Read the comment docs.

@olavloiteolavloite added the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Jan 30, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Jan 30, 2021
@thiagotnunesthiagotnunes merged commit e1e9152 into master Jan 31, 2021
@thiagotnunesthiagotnunes deleted the connection-sessionpool-options branch January 31, 2021 22:53
thiagotnunes pushed a commit that referenced this pull request May 6, 2021
* feat: allow session pool settings in connection url

* fix: use NoCredentials in test
ansh0l pushed a commit to ansh0l/java-spanner that referenced this pull request Nov 10, 2022
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
Adds `pg_catalog` as an expected schema to the JDBC metadata tests.

Fixes googleapis#810
Sign up for free to join this conversation on . Already have an account? Sign in to comment
api: spannerIssues related to the googleapis/java-spanner API.cla: yesThis human has signed the Contributor License Agreement.
None yet

Successfully merging this pull request may close these issues.