Conversation

thiagotnunes

From the next major release we will be only supporting Java 8+.

From the next major release we will be only supporting Java 8+
@thiagotnunesthiagotnunes requested review from a team as code owners March 11, 2021 02:57
@generated-files-bot

Warning: This pull request is touching the following templated files:

  • ./workflows/ci.yaml
  • .kokoro/nightly/java7.cfg
  • .kokoro/presubmit/java7.cfg
  • CONTRIBUTING.md

@google-clagoogle-cla bot added the cla: yesThis human has signed the Contributor License Agreement.label Mar 11, 2021
@product-auto-labelproduct-auto-label bot added the api: spannerIssues related to the googleapis/java-spanner API.label Mar 11, 2021
@thiagotnunesthiagotnunes added the do not mergeIndicates a pull request not ready for merge, due to either quality or timing.label Mar 11, 2021
@thiagotnunes

This should only be merged when we are planning the next major bump (for CMEK, #666).

@codecov

Codecov Report

Merging #946 (a3bece7) into master (32fdd60) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #946      +/-   ##
============================================
- Coverage     85.24%   85.21%   -0.03%     
+ Complexity     2660     2570      -90     
============================================
  Files           146      146              
  Lines         14404    14159     -245     
  Branches       1395     1313      -82     
============================================
- Hits          12278    12066     -212     
- Misses         1542     1544       +2     
+ Partials        584      549      -35     
Impacted FilesCoverage ΔComplexity Δ
...a/com/google/cloud/spanner/DatabaseClientImpl.java76.69% <0.00%> (-7.77%)21.00% <0.00%> (ø%)
.../cloud/spanner/spi/v1/SpannerErrorInterceptor.java52.94% <0.00%> (-7.06%)3.00% <0.00%> (ø%)
...ud/spanner/connection/ClientSideStatementImpl.java48.88% <0.00%> (-1.12%)9.00% <0.00%> (ø%)
...oogle/cloud/spanner/PartitionedDmlTransaction.java82.02% <0.00%> (-0.59%)14.00% <0.00%> (-1.00%)
...ain/java/com/google/cloud/spanner/SessionPool.java88.73% <0.00%> (-0.53%)71.00% <0.00%> (-2.00%)
...m/google/cloud/spanner/spi/v1/GapicSpannerRpc.java81.41% <0.00%> (-0.48%)71.00% <0.00%> (-12.00%)
...e/cloud/spanner/connection/CredentialsService.java90.00% <0.00%> (-0.48%)8.00% <0.00%> (ø%)
...m/google/cloud/spanner/TransactionManagerImpl.java87.03% <0.00%> (-0.47%)21.00% <0.00%> (ø%)
.../com/google/cloud/spanner/AbstractReadContext.java86.54% <0.00%> (-0.33%)42.00% <0.00%> (-6.00%)
.../admin/instance/v1/stub/GrpcInstanceAdminStub.java96.94% <0.00%> (-0.24%)21.00% <0.00%> (-1.00%)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32fdd60...a3bece7. Read the comment docs.

@thiagotnunesthiagotnunes removed the do not mergeIndicates a pull request not ready for merge, due to either quality or timing.label Mar 18, 2021
@thiagotnunesthiagotnunes merged commit 7af1951 into master Mar 18, 2021
@thiagotnunesthiagotnunes deleted the java-8 branch March 18, 2021 04:58
@release-pleaserelease-please bot mentioned this pull request Mar 18, 2021
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Issues related to the googleapis/java-spanner API.cla: yesThis human has signed the Contributor License Agreement.
None yet

Successfully merging this pull request may close these issues.