Conversation

olavloite

Adds a non-blocking close method to Connection to support APIs that should offer only non-blocking methods to consumers (e.g. R2DBC).

The Connection interface is marked with InternalApi and documented with Internal connection API for Google Cloud Spanner. This interface may introduce breaking changes without prior notice.

cc @elefeint

@olavloiteolavloite requested review from a team as code owners March 17, 2021 13:29
@product-auto-labelproduct-auto-label bot added the api: spannerIssues related to the googleapis/java-spanner API.label Mar 17, 2021
@google-clagoogle-cla bot added the cla: yesThis human has signed the Contributor License Agreement.label Mar 17, 2021
@codecov

Codecov Report

Merging #984 (dcbf73b) into master (7af1951) will decrease coverage by 0.01%.
The diff coverage is 95.23%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #984      +/-   ##
============================================
- Coverage     85.11%   85.09%   -0.02%     
+ Complexity     2618     2617       -1     
============================================
  Files           154      154              
  Lines         14310    14319       +9     
  Branches       1331     1331              
============================================
+ Hits          12180    12185       +5     
- Misses         1564     1570       +6     
+ Partials        566      564       -2     
Impacted FilesCoverage ΔComplexity Δ
...om/google/cloud/spanner/connection/Connection.java100.00% <ø> (ø)0.00 <0.00> (ø)
...oogle/cloud/spanner/connection/ConnectionImpl.java84.13% <95.23%> (+0.08%)181.00 <1.00> (+1.00)
...le/cloud/spanner/connection/StatementExecutor.java76.92% <0.00%> (-3.85%)8.00% <0.00%> (-1.00%)
...ain/java/com/google/cloud/spanner/SessionPool.java89.12% <0.00%> (-0.20%)72.00% <0.00%> (-1.00%)
...a/com/google/cloud/spanner/SessionPoolOptions.java69.53% <0.00%> (ø)17.00% <0.00%> (-1.00%)
.../google/cloud/spanner/AbstractLazyInitializer.java100.00% <0.00%> (+7.14%)5.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7af1951...dcbf73b. Read the comment docs.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@thiagotnunesthiagotnunes changed the title feat: add closeAsync() method to Connection feat!: add closeAsync() method to Connection Mar 18, 2021
@thiagotnunesthiagotnunes merged commit e7ec96e into master Mar 18, 2021
@thiagotnunesthiagotnunes deleted the connection-close-async branch March 18, 2021 05:33
@release-pleaserelease-please bot mentioned this pull request Mar 18, 2021
thiagotnunes added a commit that referenced this pull request Mar 19, 2021
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Issues related to the googleapis/java-spanner API.cla: yesThis human has signed the Contributor License Agreement.
None yet

Successfully merging this pull request may close these issues.