Conversation

dmitry-fa

Fixes #21

@googlebotgooglebot added the cla: yesThis human has signed the Contributor License Agreement.label Dec 27, 2019
@pmakanipmakani added the kokoro:runAdd this label to force Kokoro to re-run the tests.label Dec 27, 2019
@kokoro-teamkokoro-team removed the kokoro:runAdd this label to force Kokoro to re-run the tests.label Dec 27, 2019
@codecov

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #22   +/-   ##
=========================================
  Coverage     63.29%   63.29%           
  Complexity      528      528           
=========================================
  Files            30       30           
  Lines          4719     4719           
  Branches        450      450           
=========================================
  Hits           2987     2987           
  Misses         1571     1571           
  Partials        161      161
Impacted FilesCoverage ΔComplexity Δ
...main/java/com/google/cloud/storage/BucketInfo.java81.04% <ø> (ø)84 <0> (ø)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fda3eda...acb08d4. Read the comment docs.

@chingor13

This one is not up to me. Adding Frank

@chingor13chingor13 requested review from frankyn and removed request for chingor13 December 27, 2019 17:36
@dmitry-fa

@frankyn gentle ping

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Checked in with @JesseLovelace to double check.

@frankynfrankyn merged commit 7fb1f6c into googleapis:master Jan 16, 2020
@dmitry-fadmitry-fa deleted the FA.7046 branch June 26, 2020 07:33
Sign up for free to join this conversation on . Already have an account? Sign in to comment
cla: yesThis human has signed the Contributor License Agreement.
None yet

Successfully merging this pull request may close these issues.

Cloud Storage: getStorageClass in SetStorageClassLifecycleAction is not visible