Conversation

dmitry-fa

Fixes #219

@googlebotgooglebot added the cla: yesThis human has signed the Contributor License Agreement.label Apr 6, 2020
@codecov

Codecov Report

Merging #229 into master will decrease coverage by 0.17%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #229      +/-   ##
============================================
- Coverage     63.67%   63.50%   -0.18%     
+ Complexity      548      540       -8     
============================================
  Files            31       30       -1     
  Lines          4782     4762      -20     
  Branches        428      427       -1     
============================================
- Hits           3045     3024      -21     
- Misses         1577     1578       +1     
  Partials        160      160              
Impacted FilesCoverage ΔComplexity Δ
...java/com/google/cloud/storage/BlobReadChannel.java85.71% <50.00%> (ø)16.00 <0.00> (ø)
...e/src/main/java/com/google/cloud/storage/Blob.java81.97% <91.66%> (-0.28%)29.00 <0.00> (ø)
...va/com/google/cloud/storage/StorageOperations.java

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5599f29...a7cac71. Read the comment docs.

@dmitry-fadmitry-fa requested a review from frankyn April 6, 2020 16:06
@frankynfrankyn requested a review from JesseLovelace April 6, 2020 16:29
@dmitry-fadmitry-fa requested a review from elharo April 7, 2020 09:44
@frankynfrankyn requested review from elharo and removed request for JesseLovelace April 7, 2020 16:58
@frankyn

@elharo could I get your review on this PR.

I want another perspective.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still reviewing. Thanks for putiing this together @dmitry-fa

@@ -133,12 +133,12 @@ public int read(ByteBuffer byteBuffer) throws IOException {
if (result.y().length > 0 && lastEtag != null && !Objects.equals(result.x(), lastEtag)) {
StringBuilder messageBuilder = new StringBuilder();
messageBuilder.append("Blob ").append(blob).append(" was updated while reading");
throw new StorageException(0, messageBuilder.toString());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if this will no longer be retried. Well it shouldn't be so maybe that's not an issue.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the prompt both, follow-up.

Let's move forward. LGTM.

@frankynfrankyn merged commit 4d42a4e into googleapis:master Apr 7, 2020
@dmitry-fadmitry-fa deleted the StorageIOException branch June 26, 2020 07:35
Sign up for free to join this conversation on . Already have an account? Sign in to comment
cla: yesThis human has signed the Contributor License Agreement.
None yet

Successfully merging this pull request may close these issues.

BlobReadChannel read trows a non-IOException