Conversation

frankyn

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Ensure the tests and linter pass
  • Appropriate docs were updated (if necessary)

Fixes #666 ☕️

@product-auto-labelproduct-auto-label bot added the api: storageIssues related to the googleapis/java-storage API.label Jan 12, 2021
@google-clagoogle-cla bot added the cla: yesThis human has signed the Contributor License Agreement.label Jan 12, 2021
@codecov

Codecov Report

Merging #677 (4d58f07) into master (ebb5fb2) will decrease coverage by 0.00%.
The diff coverage is 37.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #677      +/-   ##
============================================
- Coverage     64.26%   64.25%   -0.01%     
- Complexity      621      630       +9     
============================================
  Files            32       32              
  Lines          5322     5329       +7     
  Branches        521      524       +3     
============================================
+ Hits           3420     3424       +4     
  Misses         1740     1740              
- Partials        162      165       +3     
Impacted FilesCoverage ΔComplexity Δ
...om/google/cloud/storage/spi/v1/HttpStorageRpc.java1.54% <0.00%> (ø)2.00 <0.00> (ø)
...ava/com/google/cloud/storage/BlobWriteChannel.java67.28% <42.85%> (-0.72%)11.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebb5fb2...4d58f07. Read the comment docs.

@frankynfrankyn marked this pull request as ready for review January 12, 2021 18:58
@frankynfrankyn requested a review from a team January 12, 2021 18:58
@BenWhiteheadBenWhitehead added the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Jan 12, 2021
@frankynfrankyn added kokoro:force-runAdd this label to force Kokoro to re-run the tests.and removed kokoro:force-runAdd this label to force Kokoro to re-run the tests.labels Jan 12, 2021
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Jan 12, 2021
@frankynfrankyn added the automergeMerge the pull request once unit tests and other checks pass.label Jan 12, 2021
@gcf-merge-on-greengcf-merge-on-green bot merged commit 44f49e0 into master Jan 12, 2021
@gcf-merge-on-greengcf-merge-on-green bot deleted the fix-issue branch January 12, 2021 20:52
@gcf-merge-on-greengcf-merge-on-green bot removed the automergeMerge the pull request once unit tests and other checks pass.label Jan 12, 2021
Sign up for free to join this conversation on . Already have an account? Sign in to comment
api: storageIssues related to the googleapis/java-storage API.cla: yesThis human has signed the Contributor License Agreement.
None yet

Successfully merging this pull request may close these issues.

StorageException: Resumable upload is already complete.