Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ivanmkc reviewed Jun 9, 2021
Uh oh!
There was an error while loading. Please reload this page.
ivanmkc approved these changes Jun 9, 2021
| @@ -73,20 +73,28 @@ def column_names(self) -> List[str]: | |||
| gcs_source_uris.sort() | |||
| # Get the first file in sorted list | |||
| return TabularDataset._retrieve_gcs_source_columns( | |||
| self.project, gcs_source_uris[0] | |||
| return self._retrieve_gcs_source_columns( | |||
There was a problem hiding this comment.
Is there any use case where the user would want to pass in different credentials when calling dataset.column_names?
If not, this looks fine.
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.