Conversation

ji-yaqi

No description provided.

@ji-yaqiji-yaqi requested a review from a team as a code owner July 9, 2021 23:44
@google-clagoogle-cla bot added the cla: yesThis human has signed the Contributor License Agreement.label Jul 9, 2021
@product-auto-labelproduct-auto-label bot added the api: aiplatformIssues related to the AI Platform API.label Jul 9, 2021
@ji-yaqiji-yaqi requested a review from sasha-gitg July 9, 2021 23:47
@telpiriontelpirion added the automergeMerge the pull request once unit tests and other checks pass.label Jul 15, 2021
@gcf-merge-on-green

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help..com/en//administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-greengcf-merge-on-green bot removed the automergeMerge the pull request once unit tests and other checks pass.label Jul 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a few comments. Thanks!

)
from google.cloud.aiplatform.explain.metadata import metadata_builder

try:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import check should be done within methods.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


Args:
model_path:
Required. Path to load the saved model from.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this local, GCS, or both?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both, updated comments for both Tf1 and 2

import tensorflow.compat.v1 as tf
except ImportError:
raise ImportError(
"Tensorflow is not installed and is required to load saved model. "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should most likely be a more qualified statement as full will install TF 2. We may want to direct the user to install Tensorflow 1.15 directly here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ji-yaqiji-yaqi merged commit 918998c into googleapis:master Jul 20, 2021
@ji-yaqiji-yaqi deleted the explain branch July 20, 2021 22:40
Sign up for free to join this conversation on . Already have an account? Sign in to comment
api: aiplatformIssues related to the AI Platform API.cla: yesThis human has signed the Contributor License Agreement.
None yet

Successfully merging this pull request may close these issues.