Conversation

HemangChothani

Fixes #123

@HemangChothaniHemangChothani requested a review from plamut July 16, 2020 11:31
@google-clagoogle-cla bot added the cla: yesThis human has signed the Contributor License Agreement.label Jul 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the missing colons the changes look good. Samples test failures are irrelevant, as the samples have not been migrated yet.

@@ -441,6 +441,10 @@ def create_dataset(
google.cloud.bigquery.dataset.Dataset:
A new ``Dataset`` returned from the API.

Raises:
google.cloud.exceptions.Conflict
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colons are missing at the end of exception types.

…into bigquery_issue_123_conflict_errors
@plamutplamut merged commit 9c3409b into googleapis:master Jul 20, 2020
Sign up for free to join this conversation on . Already have an account? Sign in to comment
cla: yesThis human has signed the Contributor License Agreement.
None yet

Successfully merging this pull request may close these issues.

BigQuery: client.create_table raises Conflict instead of AlreadyExists