Conversation

plamut

Fixes #177. 馃

This PR fixes the error in RowIterator.to_arrow() when the method should create and use a BQ Storage client, but the optional google-cloud-bigquery-storage dependency is not installed and thus the client cannot be created.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@google-clagoogle-cla bot added the cla: yesThis human has signed the Contributor License Agreement.label Jul 23, 2020
@plamutplamut changed the title Fixes Iss 177 fix: RowIterator.to_arrow() error when BQ Storage client cannot be created Jul 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this together.

Independent of this change, should we consider something like a nox session that's parameterized to run a subset of the system or snippet tests with different combinations of optional deps?

@plamut

Depending on the number of dependency combinations that we want to test and the slowness of the target tests, it might be an overkill to run them for every PR, but how about setting up regular nightly runs? And possibly also run such an extensive suite before every release?

@plamutplamut merged commit 7afa3d7 into googleapis:master Jul 23, 2020
@plamutplamut deleted the iss-177 branch July 23, 2020 15:23
Sign up for free to join this conversation on . Already have an account? Sign in to comment
cla: yesThis human has signed the Contributor License Agreement.
None yet

Successfully merging this pull request may close these issues.

pd.read_gbq broken with 1.26.0 and pyarrow