Conversation

tswast

Follow-up to previous PR, which cached the first page of
getQueryResults. If the first page is the only page (no pageToken),
then it is unnecessary to make extra API calls from to_dataframe or
to_arrow to the BigQuery Storage API.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #362 🦕

@tswast
perf: avoid extra API calls from to_dataframe if all rows are cached
0912b88
Follow-up to previous PR, which cached the first page of
`getQueryResults`. If the first page is the only page (no `pageToken`),
then it is unnecessary to make extra API calls from `to_dataframe` or
`to_arrow` to the BigQuery Storage API.
@tswasttswast requested review from a team and stephaniewang526 November 11, 2020 18:09
@product-auto-labelproduct-auto-label bot added the api: bigqueryIssues related to the googleapis/python-bigquery API.label Nov 11, 2020
@google-clagoogle-cla bot added the cla: yesThis human has signed the Contributor License Agreement.label Nov 11, 2020
@tswasttswast mentioned this pull request Nov 11, 2020
Closed
7 tasks
@tswasttswast requested review from shollyman and removed request for stephaniewang526 November 11, 2020 18:10
shollyman
shollyman approved these changes Nov 11, 2020
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rows are coming...from inside the house!

@tswasttswast merged commit c52b317 into googleapis:master Nov 11, 2020
@tswasttswast deleted the issue362-to_dataframe branch November 11, 2020 21:03
@tswasttswast mentioned this pull request Nov 24, 2020
Merged
4 tasks
@HemangChothaniHemangChothani mentioned this pull request Nov 27, 2020
Closed
@release-pleaserelease-please bot mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on . Already have an account? Sign in to comment

@shollyman shollyman shollyman approved these changes

No one assigned
api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.
None yet
No milestone

Successfully merging this pull request may close these issues.