Conversation

plamut

Fixes #671.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamutplamut requested a review from jimfulton May 20, 2021 08:38
@plamutplamut requested a review from a team as a code owner May 20, 2021 08:38
@plamutplamut requested review from kurtisvg and removed request for a team May 20, 2021 08:38
@google-clagoogle-cla bot added the cla: yesThis human has signed the Contributor License Agreement.label May 20, 2021
@product-auto-labelproduct-auto-label bot added the api: bigqueryIssues related to the googleapis/python-bigquery API.label May 20, 2021
@plamut

Re-echoing a comment here - why wasn't this detected earlier, do we have a glitch in the CI pipeline? The PR that caused this was merged more than 3 weeks ago.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering why we didn't hit this before, but I guess this method is only called during cleanup that isn't usually needed.

Maybe we should write a test for this.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The periodic sample tests for this repo have had 37 straight days. So it's probably not (just) a glitch in the pipeline, it's that no one is watching the results.

@plamut

So it's probably not (just) a glitch in the pipeline, it's that no one is watching the results.

Where can those be seen, or is that an internal thing?
(as an external maintainer I can only the Kokoro checks here on )

@plamutplamut merged commit 591cdd8 into googleapis:master May 21, 2021
@plamutplamut deleted the iss-671 branch May 21, 2021 09:03
Sign up for free to join this conversation on . Already have an account? Sign in to comment
api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.
None yet

Successfully merging this pull request may close these issues.

AttributeError in resource_name_to_date() samples fixture