File tree

2 files changed

+17
-4
lines changed

2 files changed

+17
-4
lines changed
Original file line numberDiff line numberDiff line change
@@ -2361,7 +2361,13 @@ def lifecycle_rules(self):
23612361
elif action_type == "SetStorageClass":
23622362
yield LifecycleRuleSetStorageClass.from_api_repr(rule)
23632363
else:
2364-
raise ValueError("Unknown lifecycle rule: {}".format(rule))
2364+
warnings.warn(
2365+
"Unknown lifecycle rule type received: {}. Please upgrade to the latest version of google-cloud-storage.".format(
2366+
rule
2367+
),
2368+
UserWarning,
2369+
stacklevel=1,
2370+
)
23652371

23662372
@lifecycle_rules.setter
23672373
def lifecycle_rules(self, rules):
Original file line numberDiff line numberDiff line change
@@ -1783,15 +1783,22 @@ def test_iam_configuration_policy_w_entry(self):
17831783
self.assertTrue(config.uniform_bucket_level_access_enabled)
17841784
self.assertEqual(config.uniform_bucket_level_access_locked_time, now)
17851785

1786-
def test_lifecycle_rules_getter_unknown_action_type(self):
1786+
@mock.("warnings.warn")
1787+
def test_lifecycle_rules_getter_unknown_action_type(self, mock_warn):
17871788
NAME = "name"
17881789
BOGUS_RULE = {"action": {"type": "Bogus"}, "condition": {"age": 42}}
17891790
rules = [BOGUS_RULE]
17901791
properties = {"lifecycle": {"rule": rules}}
17911792
bucket = self._make_one(name=NAME, properties=properties)
17921793

1793-
with self.assertRaises(ValueError):
1794-
list(bucket.lifecycle_rules)
1794+
list(bucket.lifecycle_rules)
1795+
mock_warn.assert_called_with(
1796+
"Unknown lifecycle rule type received: {}. Please upgrade to the latest version of google-cloud-storage.".format(
1797+
BOGUS_RULE
1798+
),
1799+
UserWarning,
1800+
stacklevel=1,
1801+
)
17951802

17961803
def test_lifecycle_rules_getter(self):
17971804
from google.cloud.storage.bucket import (

0 commit comments

Comments
 (0)