Enable Swift Framework Support Workaround ON by default

chkuang-g · chkuang-g · commit 2af5ee3213e7 · 2022-05-11T11:14:33.000-07:00
As more pods starting to use Swift Framework, this option is turned ON
by default now.
diff --git a/source/IOSResolver/src/IOSResolver.cs b/source/IOSResolver/src/IOSResolver.cs
@@ -1054,7 +1054,7 @@ public static bool PodfileStaticLinkFrameworks {
     /// </summary>
     public static bool SwiftFrameworkSupportWorkaroundEnabled {
         get { return settings.GetBool(PREFERENCE_SWIFT_FRAMEWORK_SUPPORT_WORKAROUND,
-                                    defaultValue: false); }
+                                    defaultValue: true); }
         set {
             settings.SetBool(PREFERENCE_SWIFT_FRAMEWORK_SUPPORT_WORKAROUND, value);
         }
diff --git a/source/IOSResolver/src/IOSResolverSettingsDialog.cs b/source/IOSResolver/src/IOSResolverSettingsDialog.cs
@@ -264,7 +264,7 @@ public void OnGUI() {
 
             if (settings.podfileAddUseFrameworks) {
                 GUILayout.BeginHorizontal();
-                GUILayout.Label("Enable Swift Framework Support Workaround",
+                GUILayout.Label("(Recommended) Enable Swift Framework Support Workaround",
                     EditorStyles.boldLabel);
                 settings.swiftFrameworkSupportWorkaroundEnabled =
                     EditorGUILayout.Toggle(settings.swiftFrameworkSupportWorkaroundEnabled);

Original file line number	Diff line number	Diff line change
`@@ -1054,7 +1054,7 @@ public static bool PodfileStaticLinkFrameworks {`
`1054`	`1054`	`/// </summary>`
`1055`	`1055`	`public static bool SwiftFrameworkSupportWorkaroundEnabled {`
`1056`	`1056`	`get { return settings.GetBool(PREFERENCE_SWIFT_FRAMEWORK_SUPPORT_WORKAROUND,`
`1057`		`-defaultValue: false); }`
	`1057`	`+defaultValue: true); }`
`1058`	`1058`	`set {`
`1059`	`1059`	`settings.SetBool(PREFERENCE_SWIFT_FRAMEWORK_SUPPORT_WORKAROUND, value);`
`1060`	`1060`	`}`