This repository was archived by the owner on Mar 29, 2024. It is now read-only.

File tree

3 files changed

+4
-25
lines changed

3 files changed

+4
-25
lines changed
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@ public function Clear()
3333
* @param Context $context
3434
* @param Value $key
3535
*
36-
* //TODO: add throws
37-
*
3836
* @return Value
3937
*/
4038
public function Get(Context $context, Value $key): Value
@@ -46,8 +44,6 @@ public function Get(Context $context, Value $key): Value
4644
* @param Value $key
4745
* @param Value $value
4846
*
49-
* //TODO: add throws
50-
*
5147
* @return MapObject
5248
*/
5349
public function Set(Context $context, Value $key, Value $value): MapObject
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@
1616

1717
class Script
1818
{
19-
//private $isolate;
19+
/**
20+
* @var Context
21+
*/
2022
private $context;
2123

2224
/**
@@ -26,7 +28,6 @@ class Script
2628
*/
2729
public function __construct(Context $context, StringValue $source, ScriptOrigin $origin = null)
2830
{
29-
// $this->isolate = $context->isolate;
3031
$this->context = $context;
3132
}
3233

Original file line numberDiff line numberDiff line change
@@ -52,12 +52,6 @@ public function Set(NameValue $name, /*Data*/ $value, int $attributes = Property
5252
{
5353
}
5454

55-
//public function void SetAccessorProperty(
56-
// Local<Name> name,
57-
// Local<FunctionTemplate> getter = Local<FunctionTemplate>(),
58-
// Local<FunctionTemplate> setter = Local<FunctionTemplate>(),
59-
// PropertyAttribute attribute = None,
60-
// AccessControl settings = DEFAULT);
6155
/**
6256
* @param NameValue $name
6357
* @param \V8\FunctionTemplate $getter
@@ -103,20 +97,8 @@ public function SetNativeDataProperty(
10397
callable $getter,
10498
callable $setter = null,
10599
$attribute = PropertyAttribute::None,
106-
FunctionTemplate $receiver,
100+
FunctionTemplate $receiver = null,
107101
$settings = AccessControl::DEFAULT_ACCESS
108102
) {
109103
}
110-
111-
//public function void SetNativeDataProperty(Local<Name> name,
112-
// AccessorNameGetterCallback getter,
113-
// AccessorNameSetterCallback setter = 0,
114-
// // TODO(dcarney): gcc can't handle Local below
115-
// Handle<Value> data = Handle<Value>(),
116-
// PropertyAttribute attribute = None,
117-
// Local<AccessorSignature> signature =
118-
// Local<AccessorSignature>(),
119-
// AccessControl settings = DEFAULT);
120-
121-
122104
}

0 commit comments

Comments
 (0)