Rethink how branch / commit-message is shown in STASHES view

[goran-w]

I find it a bit distracting to see the "On <branch>:" part prefixing the commit-message, for each stash-item in the list of STASHES:

I'm aware that this is how git stash list reports stashes by default:

$ git stash list
stash@{0}: On develop: New checkbox option in Preferences: Use case-insensitive sorting in lists
stash@{1}: On develop: Use --porcelain=v2 in QueryLocalChanges
...

However, I think we can do better, and SourceGit already extracts the stash@{<N>} part before displaying the stash-items.

To me, the information about which branch the Stash was based on is mostly superfluous - when I make a stash, it's usually because I want to "break out" some code from the current branch I'm on, to be able to later re-create that code on a new/other branch.

Therefore, I think this part (up to the second colon :) of the git stash list output could be parsed out separately and moved into a tooltip (see related issue #1419), so that a larger part of the actual commit-message can be visible instead (this tooltip should also display the full commit-message, preferably with the branch-information on a separate line).

[love-linger]

At present, SourceGit uses the git stash list --format=%H%n%P%n%ct%n%gd%n%s command to query the stash list of the current repository. Its output is as follows:

14044c5a573cd64b1f0b7b1cb8a125bd952fc56e
2b3b1ef1e98a582785ad3dbe5810c466b0cfe472 05061de0aa74cb903d199269aa66e1a77a4661e8 ac3315af508d2203e408c87624038df5424093c1
1750046035
stash@{0}
On master: 123

%gd outputs the shortened reflog selector, such as stash@{0}
%s outputs the subject of this stash.

[love-linger]

What's more interesting is that some users have completely opposite opinions to yours. They hope to be able to see which branch the stash was created from.

#548

[goran-w]

@love-linger I see. That's fine, but could the "On master:" etc part (up to first colon) of the Subject line be parsed out and simply rendered (on list-item and in tooltip) using another color (maybe slightly less prominent, like gray instead of full black/white)?

That way we can more easily/quickly discern the branch-info from the actual (original, user-provided) stash/commit-message. It would be helpful, even to those who request to see the branch/parent-commit specifically...

NOTES:

• When stashing without passing a message, Git automatically assigns a slightly different message:
  • WIP on <branch>: <abbrev-SHA-from-parent-commit> <message-from-parent-commit>
• This is in contrast to the case when a message is passed while stashing:
  • On <branch>: <message-given-when-stashing>
• The <message-given-when-stashing> can have multiple lines (Subject + Description, like for an ordinary commit).
• (See also [Suggestion] When stashing, allow multi-line message and (optionally) pre-fill it from in-progress commit-message #1426.)

[goran-w]

Thanks, @love-linger - this looks great!