fix backwards-compatibility with overridden add() methods

xabbuh · nicolas-grekas · commit 86c48554f489 · 2025-06-16T08:35:25.000+02:00
diff --git a/SymfonyRuntime.php b/SymfonyRuntime.php
@@ -162,10 +162,11 @@ public function getRunner(?object $application): RunnerInterface
 
             if (!$application->getName() || !$console->has($application->getName())) {
                 $application->setName($_SERVER['argv'][0]);
-                if (method_exists($console, 'addCommand')) {
-                    $console->addCommand($application);
-                } else {
+
+                if (!method_exists($console, 'addCommand') || (new \ReflectionMethod($console, 'add'))->getDeclaringClass()->getName() !== (new \ReflectionMethod($console, 'addCommand'))->getDeclaringClass()->getName()) {
                     $console->add($application);
+                } else {
+                    $console->addCommand($application);
                 }
             }
 

Original file line number	Diff line number	Diff line change
`@@ -162,10 +162,11 @@ public function getRunner(?object $application): RunnerInterface`
`162`	`162`
`163`	`163`	`if (!$application->getName() \|\| !$console->has($application->getName())) {`
`164`	`164`	`$application->setName($_SERVER['argv'][0]);`
`165`		`-if (method_exists($console, 'addCommand')) {`
`166`		`-$console->addCommand($application);`
`167`		`-} else {`
	`165`	`+`
	`166`	`+if (!method_exists($console, 'addCommand') \|\| (new \ReflectionMethod($console, 'add'))->getDeclaringClass()->getName() !== (new \ReflectionMethod($console, 'addCommand'))->getDeclaringClass()->getName()) {`
`168`	`167`	`$console->add($application);`
	`168`	`+} else {`
	`169`	`+$console->addCommand($application);`
`169`	`170`	`}`
`170`	`171`	`}`
`171`	`172`