diff options
| author | Jeremy Evans <[email protected]> | 2025-05-30 18:25:58 -0700 |
|---|---|---|
| committer | Jeremy Evans <[email protected]> | 2025-06-06 01:24:05 +0900 |
| commit | 0b07d2a1e32a456fc302c8d970fa85782bdb98ce () | |
| tree | e8d65e3f767506fdebfdf3ba20c4dd74d946c70f | |
| parent | 2f80117ce48f83a709989a0d88eb712b123ef371 (diff) | |
Deprecate passing arguments to Set#to_set and Enumerable#to_set
Array#to_a, Hash#to_h, Enumerable#to_a, and Enumerable#to_h do not allow you to specify subclasses. This has undesired behavior when passing non-Set subclasses. All of these are currently allowed, and none make sense: ```ruby enum = [1,2,3].to_enum enum.to_set(Hash) enum.to_set(Struct.new("A", :a)) enum.to_set(ArgumentError) enum.to_set(Thread){} ``` Users who want to create instances of a subclass of Set from an enumerable should pass the enumerable to SetSubclass.new instead of using to_set.
Notes: Merged: https://.com/ruby/ruby/pull/13489
| -rw-r--r-- | common.mk | 2 | ||||
| -rw-r--r-- | prelude.rb | 9 | ||||
| -rw-r--r-- | set.c | 2 | ||||
| -rw-r--r-- | spec/ruby/core/enumerable/to_set_spec.rb | 19 |
4 files changed, 27 insertions, 5 deletions
@@ -16792,6 +16792,7 @@ set.$(OBJEXT): $(top_srcdir)/internal/array.h set.$(OBJEXT): $(top_srcdir)/internal/basic_operators.h set.$(OBJEXT): $(top_srcdir)/internal/bits.h set.$(OBJEXT): $(top_srcdir)/internal/compilers.h set.$(OBJEXT): $(top_srcdir)/internal/gc.h set.$(OBJEXT): $(top_srcdir)/internal/hash.h set.$(OBJEXT): $(top_srcdir)/internal/imemo.h @@ -16801,6 +16802,7 @@ set.$(OBJEXT): $(top_srcdir)/internal/sanitizers.h set.$(OBJEXT): $(top_srcdir)/internal/serial.h set.$(OBJEXT): $(top_srcdir)/internal/set_table.h set.$(OBJEXT): $(top_srcdir)/internal/static_assert.h set.$(OBJEXT): $(top_srcdir)/internal/symbol.h set.$(OBJEXT): $(top_srcdir)/internal/variable.h set.$(OBJEXT): $(top_srcdir)/internal/vm.h @@ -28,7 +28,14 @@ end module Enumerable # Makes a set from the enumerable object with given arguments. - def to_set(klass = Set, *args, &block) klass.new(self, *args, &block) end end @@ -7,6 +7,7 @@ #include "id.h" #include "internal.h" #include "internal/bits.h" #include "internal/hash.h" #include "internal/proc.h" #include "internal/sanitizers.h" @@ -635,6 +636,7 @@ set_i_to_set(int argc, VALUE *argv, VALUE set) argc = 1; } else { klass = argv[0]; argv[0] = set; } @@ -11,10 +11,21 @@ describe "Enumerable#to_set" do [1, 2, 3].to_set { |x| x * x }.should == Set[1, 4, 9] end - it "instantiates an object of provided as the first argument set class" do - set = [1, 2, 3].to_set(EnumerableSpecs::SetSubclass) - set.should be_kind_of(EnumerableSpecs::SetSubclass) - set.to_a.sort.should == [1, 2, 3] end it "does not need explicit `require 'set'`" do |