diff options
| author | aycabta <[email protected]> | 2019-12-13 03:57:32 +0900 |
|---|---|---|
| committer | aycabta <[email protected]> | 2019-12-13 08:54:22 +0900 |
| commit | c2dfc6d869979124a46fb0c5404956891c27575f () | |
| tree | 45aa67fb11df82804dcc02d0cb2eb539696d01ae | |
| parent | b8d6c883b3f49e6339da4fa5111dbdbe7d3c6df5 (diff) | |
Show a menu before a document
IRB should show a menu first if a completed list has plural items. But just shows document without menu if a completed list with plural items includes a perfect matched item. The behavior is a bug. This commit fixes it.
| -rw-r--r-- | lib/reline/line_editor.rb | 20 | ||||
| -rw-r--r-- | test/reline/test_key_actor_emacs.rb | 66 |
2 files changed, 81 insertions, 5 deletions
@@ -43,6 +43,7 @@ class Reline::LineEditor COMPLETION = :completion MENU = :menu JOURNEY = :journey PERFECT_MATCH = :perfect_match end @@ -599,16 +600,24 @@ class Reline::LineEditor when CompletionState::PERFECT_MATCH @dig_perfect_match_proc&.(@perfect_matched) end - is_menu = (@completion_state == CompletionState::MENU) result = complete_internal_proc(list, is_menu) return if result.nil? target, preposing, completed, postposing = result return if completed.nil? - if target <= completed and (@completion_state == CompletionState::COMPLETION or @completion_state == CompletionState::PERFECT_MATCH) - @completion_state = CompletionState::MENU if list.include?(completed) - @completion_state = CompletionState::PERFECT_MATCH @perfect_matched = completed end if target < completed @line = preposing + completed + postposing @@ -622,7 +631,8 @@ class Reline::LineEditor private def move_completed_list(list, direction) case @completion_state - when CompletionState::NORMAL, CompletionState::COMPLETION, CompletionState::MENU @completion_state = CompletionState::JOURNEY result = retrieve_completion_block return if result.nil? @@ -1287,6 +1287,72 @@ class Reline::KeyActor::Emacs::Test < Reline::TestCase assert_line('foo_ba') end def test_completion_with_completion_ignore_case @line_editor.completion_proc = proc { |word| %w{ |