diff options
| author | Olle Jonsson <[email protected]> | 2020-04-19 18:06:02 +0200 |
|---|---|---|
| committer | Hiroshi SHIBATA <[email protected]> | 2020-06-05 07:32:42 +0900 |
| commit | f61ee674d8c5871e8e81b1a7f5884635a0ee9803 () | |
| tree | aa956731f75c20eaa39b7366d0428155df685a77 | |
| parent | dd5b918cbead5fdb641118aa4e4d90e013f90df1 (diff) | |
[rubygems/rubygems] Prefer start_with? and end_with? over regex.
- In one of the cases, filenames were checked for ending with "gz" - this is changed to check for ending with ".gz" - The change was made to make it even easier to read the code, and to match only from the start of the input (as opposed to start of the line) https://.com/rubygems/rubygems/commit/aac4290271
Notes: Merged: https://.com/ruby/ruby/pull/3184
| -rw-r--r-- | lib/rubygems/command.rb | 4 | ||||
| -rw-r--r-- | lib/rubygems/remote_fetcher.rb | 2 | ||||
| -rw-r--r-- | lib/rubygems/specification.rb | 2 | ||||
| -rw-r--r-- | lib/rubygems/test_utilities.rb | 4 |
4 files changed, 7 insertions, 5 deletions
@@ -456,7 +456,9 @@ class Gem::Command until extra.empty? do ex = [] ex << extra.shift - ex << extra.shift if extra.first.to_s =~ /^[^-]/ result << ex if handles?(ex) end @@ -252,7 +252,7 @@ class Gem::RemoteFetcher data = send "fetch_#{uri.scheme}", uri, mtime, head - if data and !head and uri.to_s =~ /\.gz$/ begin data = Gem::Util.gunzip data rescue Zlib::GzipFile::Error @@ -2104,7 +2104,7 @@ class Gem::Specification < Gem::BasicSpecification end if @specification_version > CURRENT_SPECIFICATION_VERSION and - sym.to_s =~ /=$/ warn "ignoring #{sym} loading #{full_name}" if $DEBUG else super @@ -49,7 +49,7 @@ class Gem::FakeFetcher path = path.to_s @paths << path - raise ArgumentError, 'need full URI' unless path =~ %r{^https?://} unless @data.key? path raise Gem::RemoteFetcher::FetchError.new("no data for #{path}", path) @@ -67,7 +67,7 @@ class Gem::FakeFetcher if data.respond_to?(:call) data.call else - if path.to_s =~ /gz$/ and not data.nil? and not data.empty? data = Gem::Util.gunzip data end data |