summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeremy Evans <[email protected]>2023-03-23 13:44:04 -0700
committerJeremy Evans <[email protected]>2023-04-24 07:37:20 -0700
commitf8e7048348d022814736d0a7e49f2f2494db6a2f ()
treeeecca5b3e7fa827a81d71fe9cdfc6adc41b9afc9
parent73fc81199de5e567e38f7ea9067260eb6866cbf9 (diff)
Allow anonymous memberless Struct
Previously, named memberless Structs were allowed, but anonymous memberless Structs were not. Fixes [Bug #19416]
Notes: Merged: https://.com/ruby/ruby/pull/7587
-rw-r--r--spec/ruby/core/struct/new_spec.rb14
-rw-r--r--struct.c11
-rw-r--r--test/ruby/test_arity.rb1
3 files changed, 18 insertions, 8 deletions
@@ -78,6 +78,20 @@ describe "Struct.new" do
end
end
it "raises ArgumentError when there is a duplicate member" do
-> { Struct.new(:foo, :foo) }.should raise_error(ArgumentError, "duplicate member: foo")
end
@@ -637,17 +637,14 @@ rb_struct_define_under(VALUE outer, const char *name, ...)
static VALUE
rb_struct_s_def(int argc, VALUE *argv, VALUE klass)
{
- VALUE name, rest, keyword_init = Qnil;
long i;
VALUE st;
VALUE opt;
- argc = rb_scan_args(argc, argv, "1*:", NULL, NULL, &opt);
- name = argv[0];
- if (SYMBOL_P(name)) {
- name = Qnil;
- }
- else {
--argc;
++argv;
}
@@ -65,6 +65,5 @@ class TestArity < Test::Unit::TestCase
assert_arity(%w[1 2]) { "".sub!(//) }
assert_arity(%w[0 1..2]) { "".sub!{} }
assert_arity(%w[0 1+]) { exec }
- assert_arity(%w[0 1+]) { Struct.new }
end
end