diff options
| author | Nobuyoshi Nakada <[email protected]> | 2021-03-16 22:14:56 +0900 |
|---|---|---|
| committer | Nobuyoshi Nakada <[email protected]> | 2021-03-16 23:06:41 +0900 |
| commit | 382d3a4516a8177acbd23e8f87e766e38cce36a8 () | |
| tree | 62d7c47e823141e39a9720d4a90d9590cbb894d7 /enum.c | |
| parent | e61e9bcfb27580ae52b46fc7ca49c38f8fdeb8cd (diff) | |
Improve Enumerable#tally performance
Iteration per second (i/s) | |compare-ruby|built-ruby| |:------|-----------:|---------:| |tally | 52.814| 114.936| | | -| 2.18x|
Notes: Merged: https://.com/ruby/ruby/pull/4278
| -rw-r--r-- | enum.c | 20 |
1 files changed, 14 insertions, 6 deletions
@@ -1008,11 +1008,11 @@ enum_group_by(VALUE obj) return enum_hashify(obj, 0, 0, group_by_i); } -static void -tally_up(VALUE hash, VALUE group) { - VALUE tally = rb_hash_aref(hash, group); - if (NIL_P(tally)) { tally = INT2FIX(1); } else if (FIXNUM_P(tally) && tally < INT2FIX(FIXNUM_MAX)) { @@ -1021,14 +1021,22 @@ tally_up(VALUE hash, VALUE group) else { tally = rb_big_plus(tally, INT2FIX(1)); } - rb_hash_aset(hash, group, tally); } static VALUE tally_i(RB_BLOCK_CALL_FUNC_ARGLIST(i, hash)) { ENUM_WANT_SVALUE(); - tally_up(hash, i); return Qnil; } |