diff options
| author | NARUSE, Yui <[email protected]> | 2023-06-01 08:43:22 +0900 |
|---|---|---|
| committer | NARUSE, Yui <[email protected]> | 2023-06-01 08:43:22 +0900 |
| commit | 85dcc4866d9ff29834596e9186cc97d622ee06f8 () | |
| tree | d5daa60146c5c8c2de9a9459a05e6e771d934362 /ext | |
| parent | e4163112f6b99d9c205f6bc260878dcb00954a13 (diff) | |
Revert "Hide most of the implementation of `struct rb_io`. (#6511)"
This reverts commit 18e55fc1e1ec20e8f3166e3059e76c885fc9f8f2. fix [Bug #19704] https://bugs.ruby-lang.org/issues/19704 This breaks compatibility for extension libraries. Such changes need a discussion.
| -rw-r--r-- | ext/objspace/depend | 1 | ||||
| -rw-r--r-- | ext/objspace/objspace_dump.c | 1 | ||||
| -rw-r--r-- | ext/pty/pty.c | 54 | ||||
| -rw-r--r-- | ext/stringio/stringio.c | 4 |
4 files changed, 33 insertions, 27 deletions
@@ -580,7 +580,6 @@ objspace_dump.o: $(top_srcdir)/internal/compilers.h objspace_dump.o: $(top_srcdir)/internal/gc.h objspace_dump.o: $(top_srcdir)/internal/hash.h objspace_dump.o: $(top_srcdir)/internal/imemo.h -objspace_dump.o: $(top_srcdir)/internal/io.h objspace_dump.o: $(top_srcdir)/internal/sanitizers.h objspace_dump.o: $(top_srcdir)/internal/serial.h objspace_dump.o: $(top_srcdir)/internal/static_assert.h @@ -18,7 +18,6 @@ #include "internal/class.h" #include "internal/gc.h" #include "internal/hash.h" -#include "internal/io.h" #include "internal/string.h" #include "internal/sanitizers.h" #include "symbol.h" @@ -448,10 +448,8 @@ pty_close_pty(VALUE assoc) for (i = 0; i < 2; i++) { io = rb_ary_entry(assoc, i); - if (RB_TYPE_P(io, T_FILE)) { - /* it's OK to call rb_io_close again even if it's already closed */ rb_io_close(io); - } } return Qnil; } @@ -501,21 +499,28 @@ pty_open(VALUE klass) { int master_fd, slave_fd; char slavename[DEVICELEN]; getDevice(&master_fd, &slave_fd, slavename, 1); - VALUE master_path = rb_obj_freeze(rb_sprintf("masterpty:%s", slavename)); - VALUE master_io = rb_io_open_descriptor(rb_cIO, master_fd, FMODE_READWRITE | FMODE_SYNC | FMODE_DUPLEX, master_path, RUBY_IO_TIMEOUT_DEFAULT, NULL); - - VALUE slave_path = rb_obj_freeze(rb_str_new_cstr(slavename)); - VALUE slave_file = rb_io_open_descriptor(rb_cFile, slave_fd, FMODE_READWRITE | FMODE_SYNC | FMODE_DUPLEX | FMODE_TTY, slave_path, RUBY_IO_TIMEOUT_DEFAULT, NULL); - VALUE assoc = rb_assoc_new(master_io, slave_file); if (rb_block_given_p()) { return rb_ensure(rb_yield, assoc, pty_close_pty, assoc); } - return assoc; } @@ -572,27 +577,30 @@ pty_getpty(int argc, VALUE *argv, VALUE self) { VALUE res; struct pty_info info; char SlaveName[DEVICELEN]; establishShell(argc, argv, &info, SlaveName); - VALUE pty_path = rb_obj_freeze(rb_str_new_cstr(SlaveName)); - VALUE rport = rb_io_open_descriptor( - rb_cFile, info.fd, FMODE_READABLE, pty_path, RUBY_IO_TIMEOUT_DEFAULT, NULL - ); - int wpty_fd = rb_cloexec_dup(info.fd); - if (wpty_fd == -1) { rb_sys_fail("dup()"); - } - VALUE wport = rb_io_open_descriptor( - rb_cFile, wpty_fd, FMODE_WRITABLE | FMODE_TRUNC | FMODE_CREATE | FMODE_SYNC, - pty_path, RUBY_IO_TIMEOUT_DEFAULT, NULL - ); res = rb_ary_new2(3); - rb_ary_store(res, 0, rport); - rb_ary_store(res, 1, wport); rb_ary_store(res,2,PIDT2NUM(info.child_pid)); if (rb_block_given_p()) { @@ -276,7 +276,7 @@ strio_init(int argc, VALUE *argv, struct StringIO *ptr, VALUE self) { VALUE string, vmode, opt; int oflags; - struct rb_io_encoding convconfig; argc = rb_scan_args(argc, argv, "02:", &string, &vmode, &opt); rb_io_extract_modeenc(&vmode, 0, opt, &oflags, &ptr->flags, &convconfig); @@ -1743,7 +1743,7 @@ strio_set_encoding(int argc, VALUE *argv, VALUE self) else { enc = rb_find_encoding(ext_enc); if (!enc) { - struct rb_io_encoding convconfig; int oflags, fmode; VALUE vmode = rb_str_append(rb_str_new_cstr("r:"), ext_enc); rb_io_extract_modeenc(&vmode, 0, Qnil, &oflags, &fmode, &convconfig); |