diff options
| author | Jean Boussier <[email protected]> | 2025-05-23 09:28:56 +0200 |
|---|---|---|
| committer | Hiroshi SHIBATA <[email protected]> | 2025-05-26 11:46:12 +0900 |
| commit | f171a263f76d6505b891f848bc5393ebbb973be3 () | |
| tree | 449db66c4f2c00e83aa3c43b8f7d3e7076689065 /ext | |
| parent | aa00a2d07bf56fc5def659e06104eb3173803ca7 (diff) | |
[ruby/json] Fix: generate_json_float to reserve enough memory for large negative floats.
Fix: https://.com/ruby/json/issues/807 Since https://.com/ruby/json/pull/800, `fpconv_dtoa` can actually generate up to 28 chars. https://.com/ruby/json/commit/d73ae93d3c
| -rw-r--r-- | ext/json/generator/generator.c | 5 | ||||
| -rw-r--r-- | ext/json/vendor/fpconv.c | 8 |
2 files changed, 6 insertions, 7 deletions
@@ -1406,10 +1406,9 @@ static void generate_json_float(FBuffer *buffer, struct generate_json_data *data } /* This implementation writes directly into the buffer. We reserve - * the 24 characters that fpconv_dtoa states as its maximum, plus - * 2 more characters for the potential ".0" suffix. */ - fbuffer_inc_capa(buffer, 26); char* d = buffer->ptr + buffer->len; int len = fpconv_dtoa(value, d); @@ -432,8 +432,8 @@ static int filter_special(double fp, char* dest) * * Input: * fp -> the double to convert, dest -> destination buffer. - * The generated string will never be longer than 24 characters. - * Make sure to pass a pointer to at least 24 bytes of memory. * The emitted string will not be null terminated. * * Output: @@ -443,7 +443,7 @@ static int filter_special(double fp, char* dest) * * void print(double d) * { - * char buf[24 + 1] // plus null terminator * int str_len = fpconv_dtoa(d, buf); * * buf[str_len] = '\0'; @@ -451,7 +451,7 @@ static int filter_special(double fp, char* dest) * } * */ -static int fpconv_dtoa(double d, char dest[24]) { char digits[18]; |