diff options
| author | Jean Boussier <[email protected]> | 2024-07-12 12:23:24 +0200 |
|---|---|---|
| committer | git <[email protected]> | 2024-11-12 02:13:15 +0000 |
| commit | 83702f7157a8c74dd4d7d6d79dea78d90a7b6570 () | |
| tree | 80253f40b7f8bb32858673d93cf3cefe9ccb2d5f /lib/pp.rb | |
| parent | 107a4da122126e6d0e0ad12898d7511e472709a3 (diff) | |
[ruby/pp] Handle BasicObject
Right now attempting to pretty print a BasicObject or any other object lacking a few core Object methods will result in an error ``` Error: test_basic_object(PPTestModule::PPInspectTest): NoMethodError: undefined method `is_a?' for an instance of BasicObject lib/pp.rb:192:in `pp' lib/pp.rb:97:in `block in pp' lib/pp.rb:158:in `guard_inspect_key' lib/pp.rb:97:in `pp' test/test_pp.rb:131:in `test_basic_object' 128: 129: def test_basic_object 130: a = BasicObject.new => 131: assert_match(/\A#<BasicObject:0x[\da-f]+>\n\z/, PP.pp(a, ''.dup)) 132: end 133: end 134: ``` With some fairly small changes we can fallback to `Object#inspect` which is better than an error. https://.com/ruby/pp/commit/4e9f6c2de0
| -rw-r--r-- | lib/pp.rb | 8 |
1 files changed, 6 insertions, 2 deletions
@@ -189,7 +189,7 @@ class PP < PrettyPrint def pp(obj) # If obj is a Delegator then use the object being delegated to for cycle # detection - obj = obj.__getobj__ if defined?(::Delegator) and obj.is_a?(::Delegator) if check_inspect_key(obj) group {obj.pretty_print_cycle self} @@ -198,7 +198,11 @@ class PP < PrettyPrint begin push_inspect_key(obj) - group {obj.pretty_print self} ensure pop_inspect_key(obj) unless PP.sharing_detection end |