diff options
| author | David RodrÃguez <[email protected]> | 2020-06-06 22:29:56 +0200 |
|---|---|---|
| committer | Hiroshi SHIBATA <[email protected]> | 2020-06-18 19:14:15 +0900 |
| commit | a8f9a97d49af4c814c899fda2a47a715ae740f62 () | |
| tree | facf2a7225e780c484384c04abb19aad8c29819f /spec/bundler/commands/check_spec.rb | |
| parent | acd82bd923ddaa2e3f5afbdc8fc087d28b62f55d (diff) | |
[rubygems/rubygems] Remove broken test
It turns out that this test is checking essentially nothing useful. The paperclip gem doesn't exist in our setup, so initial install is failing and the test is only checking that calling `bundle check` 3 times on a broken setup always returns the same thing. I went to the history of this test: * https://.com/rubygems/bundler/commit/105654a31e07e9b0a198f1a5a5ec94e365854edf * https://.com/rubygems/bundler/commit/ae53be1f8748bfc41bc6565dc4922a1c0ac80998 * https://.com/rubygems/bundler/commit/d19f4a7b32ccf4ec4ecda5c7c0354adc81e1efb6 * https://.com/rubygems/bundler/commit/092f169d01472336598e29b32550399991940d63 * https://.com/rubygems/bundler/commit/36878435b5f0be75fc6f2e07cebd7f15aaddadf0 And have finally decided to remove it since I'm not sure changing it to something else will lead to testing something useful and not already tested. https://.com/rubygems/rubygems/commit/6184322967
Notes: Merged: https://.com/ruby/ruby/pull/3212
| -rw-r--r-- | spec/bundler/commands/check_spec.rb | 15 |
1 files changed, 0 insertions, 15 deletions
@@ -210,21 +210,6 @@ RSpec.describe "bundle check" do expect(err).not_to include("Unfortunately, a fatal error has occurred. ") end - it "should not crash when called multiple times on a new machine" do - gemfile <<-G - gem 'rails', '3.0.0.beta3' - gem 'paperclip', :git => 'git://.com/thoughtbot/paperclip.git' - G - - simulate_new_machine - bundle "check" - last_out = out - 3.times do - bundle :check - expect(out).to eq(last_out) - end - end - it "fails when there's no lock file and frozen is set" do install_gemfile! <<-G source "#{file_uri_for(gem_repo1)}" |