diff options
author | Jeremy Evans <[email protected]> | 2019-09-20 19:06:22 -0700 |
---|---|---|
committer | Jeremy Evans <[email protected]> | 2019-11-18 01:00:25 +0200 |
commit | c5c05460ac20abcbc0ed686eb4acf06da7a39a79 () | |
tree | 991109a68f3b1cd2e256a936701d3b2badd3ddac /transcode.c | |
parent | 7b6a8b5b54448235e17ed187d9d73f56893e1b6f (diff) |
Warn on access/modify of $SAFE, and remove effects of modifying $SAFE
This removes the security features added by $SAFE = 1, and warns for access or modification of $SAFE from Ruby-level, as well as warning when calling all public C functions related to $SAFE. This modifies some internal functions that took a safe level argument to no longer take the argument. rb_require_safe now warns, rb_require_string has been added as a version that takes a VALUE and does not warn. One public C function that still takes a safe level argument and that this doesn't warn for is rb_eval_cmd. We may want to consider adding an alternative method that does not take a safe level argument, and warn for rb_eval_cmd.
Notes: Merged: https://.com/ruby/ruby/pull/2476
-rw-r--r-- | transcode.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -375,7 +375,7 @@ load_transcoder_entry(transcoder_entry_t *entry) rb_str_set_len(fn, total_len); FL_UNSET(fn, FL_TAINT); OBJ_FREEZE(fn); - rb_require_safe(fn, rb_safe_level()); } if (entry->transcoder) |