diff options
| author | Peter Zhu <[email protected]> | 2025-01-21 16:36:03 -0500 |
|---|---|---|
| committer | Peter Zhu <[email protected]> | 2025-01-22 08:54:52 -0500 |
| commit | 89240eb2fbdbd9a46788b4976cd4bdf4cc58ada2 () | |
| tree | 5e3559e4506a9dab59f67edcae9fbcc7b81cef3e /variable.c | |
| parent | 7070b1b1968f31f999636b42a1af872458cd5a81 (diff) | |
Add generic ivar reference updating step
Previously, generic ivars worked differently than the other global tables during compaction. The other global tables had their references updated through iteration during rb_gc_update_vm_references. Generic ivars updated the keys when the object moved and updated the values while reference updating the object. This is inefficient as this required one lookup for every moved object and one lookup for every object with generic ivars. Instead, this commit changes it to iterate over the generic ivar table to update both the keys and values.
Notes: Merged: https://.com/ruby/ruby/pull/12607
| -rw-r--r-- | variable.c | 43 |
1 files changed, 26 insertions, 17 deletions
@@ -1136,31 +1136,40 @@ rb_mark_generic_ivar(VALUE obj) } } -void -rb_ref_update_generic_ivar(VALUE obj) { - struct gen_ivtbl *ivtbl; - if (rb_gen_ivtbl_get(obj, 0, &ivtbl)) { - if (rb_shape_obj_too_complex(obj)) { - rb_gc_ref_update_table_values_only(ivtbl->as.complex.table); - } - else { - for (uint32_t i = 0; i < ivtbl->as.shape.numiv; i++) { - ivtbl->as.shape.ivptr[i] = rb_gc_location(ivtbl->as.shape.ivptr[i]); - } } } } void -rb_mv_generic_ivar(VALUE rsrc, VALUE dst) { - st_data_t key = (st_data_t)rsrc; - st_data_t ivtbl; - - if (st_delete(generic_ivtbl_no_ractor_check(rsrc), &key, &ivtbl)) - st_insert(generic_ivtbl_no_ractor_check(dst), (st_data_t)dst, ivtbl); } void |