12 files changed, 35 insertions, 35 deletions
@@ -429,7 +429,7 @@ An Array (#{env.inspect}) was passed in from #{caller[3]}
 def self.ensure_subdirectories(dir, mode, subdirs) # :nodoc:
 old_umask = File.umask
- File.umask old_umask | 002
 options = {}
@@ -178,7 +178,7 @@ class Gem::Commands::CertCommand < Gem::Command
 algorithm = options[:key_algorithm] || Gem::Security::DEFAULT_KEY_ALGORITHM
 key = Gem::Security.create_key(algorithm)
- key_path = Gem::Security.write key, "gem-private_key.pem", 0600, passphrase
 [key, key_path]
 end
@@ -291,7 +291,7 @@ For further reading on signing gems see `ri Gem::Security`.
 cert = File.read cert_file
 cert = OpenSSL::X509::Certificate.new cert
- permissions = File.stat(cert_file).mode & 0777
 issuer_cert = options[:issuer_cert]
 issuer_key = options[:key]
@@ -243,7 +243,7 @@ By default, this RubyGems will install gem as:
 end
 def install_executables(bin_dir)
- prog_mode = options[:prog_mode] || 0755
 executables = { "gem" => "bin" }
 executables.each do |tool, path|
@@ -369,7 +369,7 @@ By default, this RubyGems will install gem as:
 File.dirname(loaded_from)
 else
 target_specs_dir = File.join(default_dir, "specifications", "default")
- mkdir_p target_specs_dir, :mode => 0755
 target_specs_dir
 end
@@ -393,7 +393,7 @@ By default, this RubyGems will install gem as:
 end
 bundler_bin_dir = bundler_spec.bin_dir
- mkdir_p bundler_bin_dir, :mode => 0755
 bundler_spec.executables.each do |e|
 cp File.join("bundler", bundler_spec.bindir, e), File.join(bundler_bin_dir, e)
 end
@@ -430,8 +430,8 @@ By default, this RubyGems will install gem as:
 lib_dir, bin_dir = generate_default_dirs
 end
- mkdir_p lib_dir, :mode => 0755
- mkdir_p bin_dir, :mode => 0755
 [lib_dir, bin_dir]
 end
@@ -639,10 +639,10 @@ abort "#{deprecation_message}"
 dest_file = File.join dest_dir, file
 dest_dir = File.dirname dest_file
 unless File.directory? dest_dir
- mkdir_p dest_dir, :mode => 0755
 end
- install file, dest_file, :mode => options[:data_mode] || 0644
 end
 def remove_file_list(files, dir)
@@ -241,9 +241,9 @@ class Gem::ConfigFile
 return if Gem.win_platform? # windows doesn't write 0600 as 0600
 return unless File.exist? credentials_path
- existing_permissions = File.stat(credentials_path).mode & 0777
- return if existing_permissions == 0600
 alert_error <<-ERROR
 Your gem push credentials file located at:
@@ -326,7 +326,7 @@ if you believe they were disclosed to a third party.
 Gem.load_yaml
- permissions = 0600 & (~File.umask)
 File.open(credentials_path, "w", permissions) do |f|
 f.write config.to_yaml
 end
@@ -327,7 +327,7 @@ class Gem::Indexer
 def make_temp_directories
 FileUtils.rm_rf @directory
- FileUtils.mkdir_p @directory, :mode => 0700
 FileUtils.mkdir_p @quick_marshal_dir
 end
@@ -316,7 +316,7 @@ class Gem::Installer
 FileUtils.rm_rf spec.extension_dir
 dir_mode = options[:dir_mode]
- FileUtils.mkdir_p gem_dir, :mode => dir_mode && 0755
 if @options[:install_as_default]
 extract_bin
@@ -495,7 +495,7 @@ class Gem::Installer
 next unless File.exist? bin_path
 mode = File.stat(bin_path).mode
- dir_mode = options[:prog_mode] || (mode | 0111)
 unless dir_mode == mode
 require "fileutils"
@@ -540,9 +540,9 @@ class Gem::Installer
 require "fileutils"
 FileUtils.rm_f bin_script_path # prior install may have been --no-wrappers
- File.open bin_script_path, "wb", 0755 do |file|
 file.print app_script_text(filename)
- file.chmod(options[:prog_mode] || 0755)
 end
 verbose bin_script_path
@@ -712,7 +712,7 @@ class Gem::Installer
 end
 def verify_gem_home # :nodoc:
- FileUtils.mkdir_p gem_home, :mode => options[:dir_mode] && 0755
 raise Gem::FilePermissionError, gem_home unless File.writable?(gem_home)
 end
@@ -934,7 +934,7 @@ TEXT
 build_info_dir = File.join gem_home, "build_info"
 dir_mode = options[:dir_mode]
- FileUtils.mkdir_p build_info_dir, :mode => dir_mode && 0755
 build_info_file = File.join build_info_dir, "#{spec.full_name}.info"
@@ -957,7 +957,7 @@ TEXT
 def ensure_writable_dir(dir) # :nodoc:
 begin
- Dir.mkdir dir, *[options[:dir_mode] && 0755].compact
 rescue SystemCallError
 raise unless File.directory? dir
 end
@@ -230,7 +230,7 @@ class Gem::Package
 end
 end
- tar.add_file_signed "checksums.yaml.gz", 0444, @signer do |io|
 gzip_to io do |gz_io|
 Psych.dump checksums_by_algorithm, gz_io
 end
@@ -242,7 +242,7 @@ class Gem::Package
 # and adds this file to the +tar+.
 def add_contents(tar) # :nodoc:
- digests = tar.add_file_signed "data.tar.gz", 0444, @signer do |io|
 gzip_to io do |gz_io|
 Gem::Package::TarWriter.new gz_io do |data_tar|
 add_files data_tar
@@ -278,7 +278,7 @@ class Gem::Package
 # Adds the package's Gem::Specification to the +tar+ file
 def add_metadata(tar) # :nodoc:
- digests = tar.add_file_signed "metadata.gz", 0444, @signer do |io|
 gzip_to io do |gz_io|
 gz_io.write @spec.to_yaml
 end
@@ -382,7 +382,7 @@ EOM
 def extract_files(destination_dir, pattern = "*")
 verify unless @spec
- FileUtils.mkdir_p destination_dir, :mode => dir_mode && 0755
 @gem.with_read_io do |io|
 reader = Gem::Package::TarReader.new io
@@ -432,7 +432,7 @@ EOM
 FileUtils.rm_rf destination
 mkdir_options = {}
- mkdir_options[:mode] = dir_mode ? 0755 : (entry.header.mode if entry.directory?)
 mkdir =
 if entry.directory?
 destination
@@ -468,7 +468,7 @@ EOM
 end
 def file_mode(mode) # :nodoc:
- ((mode & 0111).zero? ? data_mode : prog_mode) ||
 # If we're not using one of the default modes, then we're going to fall
 # back to the mode from the tarball. In this case we need to mask it down
 # to fit into 2^16 bits (the maximum value for a mode in CRuby since it
@@ -78,7 +78,7 @@ class Gem::Package::Old < Gem::Package
 FileUtils.rm_rf destination
- FileUtils.mkdir_p File.dirname(destination), :mode => dir_mode && 0755
 File.open destination, "wb", file_mode(entry["mode"]) do |out|
 out.write file_data
@@ -192,7 +192,7 @@ class Gem::Package::TarWriter
 if signer.key
 signature = signer.sign signature_digest.digest
- add_file_simple "#{name}.sig", 0444, signature.length do |io|
 io.write signature
 end
 end
@@ -589,7 +589,7 @@ module Gem::Security
 # +permissions+. If passed +cipher+ and +passphrase+ those arguments will be
 # passed to +to_pem+.
- def self.write(pemmable, path, permissions = 0600, passphrase = nil, cipher = KEY_CIPHER)
 path = File.expand_path path
 File.open path, "wb", permissions do |io|
@@ -9,8 +9,8 @@ class Gem::Security::TrustDir
 # Default permissions for the trust directory and its contents
 DEFAULT_PERMISSIONS = {
- :trust_dir => 0700,
- :trusted_cert => 0600,
 }.freeze
 ##
@@ -91,7 +91,7 @@ class Gem::Security::TrustDir
 destination = cert_path certificate
- File.open destination, "wb", 0600 do |io|
 io.write certificate.to_pem
 io.chmod(@permissions[:trusted_cert])
 end
@@ -109,7 +109,7 @@ class Gem::Security::TrustDir
 "trust directory #{@dir} is not a directory" unless
 File.directory? @dir
- FileUtils.chmod 0700, @dir
 else
 FileUtils.mkdir_p @dir, :mode => @permissions[:trust_dir]
 end
@@ -234,7 +234,7 @@ duplicate dependency on #{dep}, (#{prev.requirement}) use:
 @specification.files.each do |file|
 next unless File.file?(file)
- next if File.stat(file).mode & 0444 == 0444
 warning "#{file} is not world-readable"
 end