Age | Commit message (Collapse) | Author |
---|
| https://.com/ruby/did_you_mean/commit/1cce337962 |
| https://.com/ruby/did_you_mean/commit/24c06dd509 |
| degradation closes https://.com/ruby/did_you_mean/pull/100 https://.com/ruby/did_you_mean/commit/bd11eefd6c |
| https://.com/ruby/did_you_mean/commit/cb518e251a |
| The variable ``length2`` is an Integer, call to floor returns self. The variables ``i`` and ``prefix_bonus`` are equally incremented, no need to keep the ``i`` variable. https://.com/ruby/did_you_mean/commit/4408802289 |
| https://.com/ruby/did_you_mean/commit/f7703add76 |
| (https://.com/ruby/did_you_mean/pull/180) * Do not suggest #name= for #name and vice versa * Avoid allocating unnecessary MatchData Co-authored-by: Jean byroot Boussier <[email protected]> Co-authored-by: Jean byroot Boussier <[email protected]> |
| https://.com/ruby/did_you_mean/commit/f5b15128e2 |
| https://.com/ruby/did_you_mean/commit/c3fc412f6f |
| |
| warning. (https://.com/ruby/did_you_mean/pull/172) ``` did_you_mean/formatters/verbose_formatter.rb:5: warning: `frozen_string_literal' is ignored after any tokens ``` https://.com/ruby/did_you_mean/commit/531760f323 |
| |
| This reverts commit feaf4fbc3fa16382fbd07158c448c7b5bdae78b5. This reverts commit 0d4bfbdbe1f880c712b3e60de5fce423e6096f8d. This reverts commit ac4e0978ee4358430396403065eabe1aca05784f. |
| |
| This reverts commit 4560091b1c99ab33db0d653b9dd2d977fe4676d5. This reverts commit a6f76122a2395bd914daa0aa04fb5a6ce4e0c045. This reverts commit e59b18a6379c55f15ccda85c27d6997d44ef5293. This reverts commit 505dfae05d56d844ea150676edb87850a406d071. |
| |
| |
| This reverts commit e22d293e06966733e71a7fd9725eee06c03d0177. |
| |
| Previously, did_you_mean used `msg.end_with?(suggestion)` to check if its suggestion is already added. I'm now creating a gem that also modifies Exception's message. This breaks did_you_mean's duplication check. This change makes the check use String#include? instead of end_with?. https://.com/ruby/did_you_mean/commit/b35e030549 |
| Previously, DidYouMean::Correctable#original_message did `method(:to_s).super_method.call` to call the original to_s method by skipping Correctable#to_s. I'm now creating a gem that prepends another to_s method to NameError, which confuses the hack. An immediate solution is to replace it with `method(:to_s).super_method.super_method.call` to skip the two methods. But it is too ad-hoc. This changeset uses more extensible approach and allow a prepended module to declare that they should be skipped by defining a constant named `SKIP_TO_S_FOR_SUPER_LOOKUP`. https://.com/ruby/did_you_mean/commit/8352c154e3 |
| https://.com/ruby/did_you_mean/commit/fbe5aaaae8 |
| https://.com/ruby/did_you_mean/commit/3f69171813 |
| |
| Original pull request: https://.com/ruby/did_you_mean/pull/147 |
| Notes: Merged: https://.com/ruby/ruby/pull/3135 |
| This reverts commit 946dadd3f479198e87873a863d15c7660a8e2b56, which broke `TestGemRequire` and others. |
| |
| |
| Original comment: https://.com/ruby/did_you_mean/commit/2f26c9ee770f28da0942c42cbc9e5800535b75e1 |
| ``` .../gems/did_you_mean-1.3.1/lib/did_you_mean/version.rb:2: warning: already initialized constant DidYouMean::VERSION .../lib/did_you_mean/version.rb:2: warning: previous definition of VERSION was here ``` |
| |
| At the moment, there are some problems with regard to bundler + did_you_mean because of did_you_mean being a bundled gem. Since the vendored version of thor inside bundler and ruby itself explicitly requires did_you_mean, it can become difficult to load it when using Bundler.setup. See this issue: https://.com/yuki24/did_you_mean/issues/117#issuecomment-482733159 for more details. Notes: Merged: https://.com/ruby/ruby/pull/2689 |