| Age | Commit message (Collapse) | Author |
|---|
| Notes: Merged: https://.com/ruby/ruby/pull/13626 |
| Notes: Merged: https://.com/ruby/ruby/pull/13621 |
| Now that the shape_id gives us all the same information, it's no longer needed. Notes: Merged: https://.com/ruby/ruby/pull/13612 |
| We still keep setting `FL_EXIVAR` so that `rb_shape_verify_consistency` can detect discrepancies. Notes: Merged: https://.com/ruby/ruby/pull/13612 |
| The FL_EXIVAR is a bit redundant with the shape_id. Now that the `shape_id` is embedded in all objects on all archs, we can cheaply check if an object has any fields with a simple bitmask. Notes: Merged: https://.com/ruby/ruby/pull/13612 |
| |
| This allow checking if an object has ivars with just a shape_id mask. Notes: Merged: https://.com/ruby/ruby/pull/13606 |
| |
| id_frozen and id_t_object are no longer used. id_object_id no longer need to be exposed. Notes: Merged: https://.com/ruby/ruby/pull/13605 |
| There is no point allocating it during init, it adds a useless indirection. Notes: Merged: https://.com/ruby/ruby/pull/13596 |
| It's a useless indirection. Notes: Merged: https://.com/ruby/ruby/pull/13596 |
| Notes: Merged: https://.com/ruby/ruby/pull/13596 |
| Since the shape_tree_ptr is `extern` it should be possible to fully inline `RSHAPE`. Notes: Merged: https://.com/ruby/ruby/pull/13596 |
| Now that classes fields are delegated to an object with its own shape_id, we no longer need to mark all classes as TOO_COMPLEX. Notes: Merged: https://.com/ruby/ruby/pull/13595 |
| This behave almost exactly as a T_OBJECT, the layout is entirely compatible. This aims to solve two problems. First, it solves the problem of namspaced classes having a single `shape_id`. Now each namespaced classext has an object that can hold the namespace specific shape. Second, it open the door to later make class instance variable writes atomics, hence be able to read class variables without locking the VM. In the future, in multi-ractor mode, we can do the write on a copy of the `fields_obj` and then atomically swap it. Considerations: - Right now the `RClass` shape_id is always synchronized, but with namespace we should likely mark classes that have multiple namespace with a specific shape flag. Notes: Merged: https://.com/ruby/ruby/pull/13411 |
| The type isn't opaque because Ruby isn't often compiled with LTO, so for optimization purpose it's better to allow as much inlining as possible. However ideally only `shape.c` and `shape.h` should deal with the actual struct, and everything else should just deal with opaque `shape_id_t`. Notes: Merged: https://.com/ruby/ruby/pull/13586 |
| Notes: Merged: https://.com/ruby/ruby/pull/13583 |
| Notes: Merged: https://.com/ruby/ruby/pull/13578 |
| Now that `rb_shape_traverse_from_new_root` has been eliminated there's no longer any reason to pin these objects, because we no longer need to traverse shapes downward during compaction. Notes: Merged: https://.com/ruby/ruby/pull/13556 |
| Now that there no longer multiple shape roots, all we need to do when moving an object from one slot to the other is to update the `heap_index` part of the shape_id. Since this never need to create a shape transition, it will always work and never result in a complex shape. Notes: Merged: https://.com/ruby/ruby/pull/13556 |
| Notes: Merged: https://.com/ruby/ruby/pull/13556 |
| Now that we have the `heap_index` in shape flags we no longer need `T_OBJECT` shapes. Notes: Merged: https://.com/ruby/ruby/pull/13556 |
| Notes: Merged: https://.com/ruby/ruby/pull/13556 |
| Notes: Merged: https://.com/ruby/ruby/pull/13556 |
| This is preparation to getting rid of `T_OBJECT` transitions. By first only replicating the information it's easier to ensure consistency. Notes: Merged: https://.com/ruby/ruby/pull/13556 |
| This used to be protected because all shape code was under a lock, but now that the shape tree is lock-free we still need to lock around the red-black cache. Co-Authored-By: Luke Gruber <[email protected]> Notes: Merged: https://.com/ruby/ruby/pull/13552 |
| This helps with getting with of `SHAPE_T_OBJECT`, by ensuring that transitions will have capacities that match the next embed size. Notes: Merged: https://.com/ruby/ruby/pull/13548 |
| Meant to be `transition_complex` not `transition_frozen`. |
| Notes: Merged: https://.com/ruby/ruby/pull/13524 |
| This method was moved to RubyVM::Shape in 913979bede2a1b79109fa2072352882560d55fe0. |
| Now all flags are only in the `shape_id_t`, and can all be checked without needing to dereference a pointer. Notes: Merged: https://.com/ruby/ruby/pull/13515 |
| Instead it's now a `shape_id` flag. This allows to check if an object is complex without having to chase the `rb_shape_t` pointer. Notes: Merged: https://.com/ruby/ruby/pull/13511 |
| Notes: Merged: https://.com/ruby/ruby/pull/13289 |
| Instead `shape_id_t` higher bits contain flags, and the first one tells whether the shape is frozen. This has multiple benefits: - Can check if a shape is frozen with a single bit check instead of dereferencing a pointer. - Guarantees it is always possible to transition to frozen. - This allow reclaiming `FL_FREEZE` (not done yet). The downside is you have to be careful to preserve these flags when transitioning. Notes: Merged: https://.com/ruby/ruby/pull/13289 |
| Notes: Merged: https://.com/ruby/ruby/pull/13441 |
| Whenever we run into an inline cache miss when we try to set an ivar, we may need to take the global lock, just to be able to lookup inside `shape->edges`. To solve that, when we're in multi-ractor mode, we can treat the `shape->edges` as immutable. When we need to add a new edge, we first copy the table, and then replace it with CAS. This increases memory allocations, however we expect that creating new transitions becomes increasingly rare over time. ```ruby class A def initialize(bool) @a = 1 if bool @b = 2 else @c = 3 end end def test @d = 4 end end def bench(iterations) i = iterations while i > 0 A.new(true).test A.new(false).test i -= 1 end end if ARGV.first == "ractor" ractors = 8.times.map do Ractor.new do bench(20_000_000 / 8) end end ractors.each(&:take) else bench(20_000_000) end ``` The above benchmark takes 27 seconds in Ractor mode on Ruby 3.4, and only 1.7s with this branch. Co-Authored-By: Étienne Barrié <[email protected]> Notes: Merged: https://.com/ruby/ruby/pull/13441 |
| Notes: Merged: https://.com/ruby/ruby/pull/13450 |
| Notes: Merged: https://.com/ruby/ruby/pull/13450 |
| Now takes a `shape_id_t` and the version that takes a `rb_shape_t *` is private. Notes: Merged: https://.com/ruby/ruby/pull/13450 |
| It still exists but only in `shape.c`. Notes: Merged: https://.com/ruby/ruby/pull/13450 |
| Notes: Merged: https://.com/ruby/ruby/pull/13450 |
| Further reduce exposure of `rb_shape_t`. Notes: Merged: https://.com/ruby/ruby/pull/13450 |
| We should avoid conversions from `rb_shape_t *` into `shape_id_t` outside of `shape.c` as the short term goal is to have `shape_id_t` contain tags. Notes: Merged: https://.com/ruby/ruby/pull/13448 |
| Notes: Merged: https://.com/ruby/ruby/pull/13448 |
| This makes `RBobject` `4B` larger on 32 bit systems but simplifies the implementation a lot. [Feature #21353] Co-authored-by: Jean Boussier <[email protected]> Notes: Merged: https://.com/ruby/ruby/pull/13341 |
| Notes: Merged: https://.com/ruby/ruby/pull/13439 |
| Move the fields management logic in `rb_ivar_delete`, and keep shape managment logic in `rb_shape_transition_remove_ivar`. Notes: Merged: https://.com/ruby/ruby/pull/13426 |
| Notes: Merged: https://.com/ruby/ruby/pull/13314 |
| The intial complex shape implementation never allowed objects other than T_OBJECT to become too complex, unless we run out of shapes. I don't see any reason to prevent that. Ref: https://.com/ruby/ruby/pull/6931 Notes: Merged: https://.com/ruby/ruby/pull/13301 |
| |
