NetworkCloud 2025-02-01 Stable API : powershell updates by mfoster58 · Pull Request #27724 · Azure/azure-powershell ·

Description

Mandatory Checklist

Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
- General release
- Public preview
- Private preview
- Engineering build
- No need for a release
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

General availability of Az.NetworkCloud module with 2025-02-01 API version
Deploy-AzNetworkCloudCluster
Disable-AzNetworkCloudStorageApplianceRemoteVendo…
Enable-AzNetworkCloudStorageApplianceRemoteVendor…
Get-AzNetworkCloudAgentPool
Get-AzNetworkCloudBareMetalMachine
Get-AzNetworkCloudBareMetalMachineKeySet
Get-AzNetworkCloudBmcKeySet
Get-AzNetworkCloudCluster
Get-AzNetworkCloudClusterManager
Get-AzNetworkCloudConsole
Get-AzNetworkCloudKubernetesCluster
Get-AzNetworkCloudKubernetesClusterFeature
Get-AzNetworkCloudL2Network
Get-AzNetworkCloudL3Network
Get-AzNetworkCloudMetricsConfiguration
Get-AzNetworkCloudRack
Get-AzNetworkCloudRackSku
Get-AzNetworkCloudServicesNetwork
Get-AzNetworkCloudStorageAppliance
Get-AzNetworkCloudTrunkedNetwork
Get-AzNetworkCloudVirtualMachine
Get-AzNetworkCloudVolume
Invoke-AzNetworkCloudBareMetalMachineCordon
Invoke-AzNetworkCloudBareMetalMachineDataExtract
Invoke-AzNetworkCloudBareMetalMachineReimage
Invoke-AzNetworkCloudBareMetalMachineReplace
Invoke-AzNetworkCloudBareMetalMachineRunCommand
Invoke-AzNetworkCloudBareMetalMachineRunReadComma…
Invoke-AzNetworkCloudBareMetalMachineUncordon
Invoke-AzNetworkCloudClusterContinueVersionUpdate
Invoke-AzNetworkCloudClusterVersionUpdate
Invoke-AzNetworkCloudScanClusterRuntime
Invoke-AzNetworkCloudVirtualMachineReimage
New-AzNetworkCloudAgentPool
New-AzNetworkCloudBareMetalMachineConfigurationDa…
New-AzNetworkCloudBareMetalMachineKeySet
New-AzNetworkCloudBgpAdvertisementObject
New-AzNetworkCloudBgpServiceLoadBalancerConfigura…
New-AzNetworkCloudBmcKeySet
New-AzNetworkCloudCluster
New-AzNetworkCloudClusterManager
New-AzNetworkCloudConsole
New-AzNetworkCloudControlPlaneNodeConfigurationOb…
New-AzNetworkCloudEgressEndpointObject
New-AzNetworkCloudEndpointDependencyObject
New-AzNetworkCloudInitialAgentPoolConfigurationOb…
New-AzNetworkCloudIpAddressPoolObject
New-AzNetworkCloudKeySetUserObject
New-AzNetworkCloudKubernetesCluster
New-AzNetworkCloudKubernetesClusterFeature
New-AzNetworkCloudL2Network
New-AzNetworkCloudL3Network
New-AzNetworkCloudL3NetworkAttachmentConfiguratio…
New-AzNetworkCloudMetricsConfiguration
New-AzNetworkCloudNetworkAttachmentObject
New-AzNetworkCloudRackDefinitionObject
New-AzNetworkCloudServiceLoadBalancerBgpPeerObject
New-AzNetworkCloudServicesNetwork
New-AzNetworkCloudStorageApplianceConfigurationDa…
New-AzNetworkCloudTrunkedNetwork
New-AzNetworkCloudVirtualMachine
New-AzNetworkCloudVirtualMachinePlacementHintObje…
New-AzNetworkCloudVolume
Remove-AzNetworkCloudAgentPool
Remove-AzNetworkCloudBareMetalMachineKeySet
Remove-AzNetworkCloudBmcKeySet
Remove-AzNetworkCloudCluster
Remove-AzNetworkCloudClusterManager
Remove-AzNetworkCloudConsole
Remove-AzNetworkCloudKubernetesCluster
Remove-AzNetworkCloudKubernetesClusterFeature
Remove-AzNetworkCloudL2Network
Remove-AzNetworkCloudL3Network
Remove-AzNetworkCloudMetricsConfiguration
Remove-AzNetworkCloudServicesNetwork
Remove-AzNetworkCloudTrunkedNetwork
Remove-AzNetworkCloudVirtualMachine
Remove-AzNetworkCloudVolume
Restart-AzNetworkCloudBareMetalMachine
Restart-AzNetworkCloudKubernetesClusterNode
Restart-AzNetworkCloudVirtualMachine
Start-AzNetworkCloudBareMetalMachine
Start-AzNetworkCloudVirtualMachine
Stop-AzNetworkCloudBareMetalMachine
Stop-AzNetworkCloudVirtualMachine
Update-AzNetworkCloudAgentPool
Update-AzNetworkCloudBareMetalMachine
Update-AzNetworkCloudBareMetalMachineKeySet
Update-AzNetworkCloudBmcKeySet
Update-AzNetworkCloudCluster
Update-AzNetworkCloudClusterManager
Update-AzNetworkCloudConsole
Update-AzNetworkCloudKubernetesCluster
Update-AzNetworkCloudKubernetesClusterFeature
Update-AzNetworkCloudL2Network
Update-AzNetworkCloudL3Network
Update-AzNetworkCloudMetricsConfiguration
Update-AzNetworkCloudRack
Update-AzNetworkCloudServicesNetwork
Update-AzNetworkCloudStorageAppliance
Update-AzNetworkCloudTrunkedNetwork
Update-AzNetworkCloudVirtualMachine
Update-AzNetworkCloudVolume

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

priyamshet · 2025-05-09T22:16:53Z

src/NetworkCloud/NetworkCloud/ChangeLog.md

@@ -19,6 +19,9 @@
 -->
 ## Upcoming Release

+## Version 1.1.0


The version likely needs an update . e.g 1.2.0, will need to confirm on this.

Bumped to 1.2.0

/azp run

Azure Pipelines successfully started running 3 pipeline(s).

Please fix the failed checks

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

…8/azure-powershell into networkcloud-2025-02-01

/azp run

Azure Pipelines successfully started running 3 pipeline(s).

Please fix the failed checks

Please fix the failed checks

Can we get some help/pointers on how to proceed with the failures we are seeing in the CI please?

@priyamshet

  "Module","Cmdlet","Example","Line","RuleName","ProblemId","Severity","Description","Extent","Remediation"
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","9","MissingEndParenthesisInMethodCall","5200","1","Missing ')' in method call.","","Unexpected Error. Please check [Trouble Shotting for Unexpected Errors in Example Issues](***/blob/main/documentation/Debugging-StaticAnalysis-Errors.md#Troubleshotting-Example-Issues) for more details."
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","9","UnexpectedToken","5200","1","Unexpected token 'userAssignedIdentityResourceId' in expression or statement.","userAssignedIdentityResourceId","Unexpected Error. Please check [Trouble Shotting for Unexpected Errors in Example Issues](***/blob/main/documentation/Debugging-StaticAnalysis-Errors.md#Troubleshotting-Example-Issues) for more details."
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","9","MissingArgument","5200","1","Missing argument in parameter list.",",","Unexpected Error. Please check [Trouble Shotting for Unexpected Errors in Example Issues](***/blob/main/documentation/Debugging-StaticAnalysis-Errors.md#Troubleshotting-Example-Issues) for more details."
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","0","MissingEndCurlyBrace","5200","1","Missing closing '}' in statement block or type definition.","{","Unexpected Error. Please check [Trouble Shotting for Unexpected Errors in Example Issues](***/blob/main/documentation/Debugging-StaticAnalysis-Errors.md#Troubleshotting-Example-Issues) for more details."
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","9","UnexpectedToken","5200","1","Unexpected token ')' in expression or statement.",")","Unexpected Error. Please check [Trouble Shotting for Unexpected Errors in Example Issues](***/blob/main/documentation/Debugging-StaticAnalysis-Errors.md#Troubleshotting-Example-Issues) for more details."
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","12","UnexpectedToken","5200","1","Unexpected token '}' in expression or statement.","}","Unexpected Error. Please check [Trouble Shotting for Unexpected Errors in Example Issues](***/blob/main/documentation/Debugging-StaticAnalysis-Errors.md#Troubleshotting-Example-Issues) for more details."
  "Az.NetworkCloud","Update-AzNetworkCloudCluster","2","10","MissingEndParenthesisInMethodCall","5200","1","Missing ')' in method call.","","Unexpected Error. Please check [Trouble Shotting for Unexpected Errors in Example Issues](***/blob/main/documentation/Debugging-StaticAnalysis-Errors.md#Troubleshotting-Example-Issues) for more details."
  "Az.NetworkCloud","Update-AzNetworkCloudCluster","2","10","UnexpectedToken","5200","1","Unexpected token 'userAssignedIdentityResourceId' in expression or statement.","userAssignedIdentityResourceId","Unexpected Error. Please check [Trouble Shotting for Unexpected Errors in Example Issues](***/blob/main/documentation/Debugging-StaticAnalysis-Errors.md#Troubleshotting-Example-Issues) for more details."
  "Az.NetworkCloud","Update-AzNetworkCloudCluster","2","10","MissingArgument","5200","1","Missing argument in parameter list.",",","Unexpected Error. Please check [Trouble Shotting for Unexpected Errors in Example Issues](***/blob/main/documentation/Debugging-StaticAnalysis-Errors.md#Troubleshotting-Example-Issues) for more details."
  "Az.NetworkCloud","Update-AzNetworkCloudCluster","2","0","MissingEndCurlyBrace","5200","1","Missing closing '}' in statement block or type definition.","{","Unexpected Error. Please check [Trouble Shotting for Unexpected Errors in Example Issues](***/blob/main/documentation/Debugging-StaticAnalysis-Errors.md#Troubleshotting-Example-Issues) for more details."
  "Az.NetworkCloud","Update-AzNetworkCloudCluster","2","10","UnexpectedToken","5200","1","Unexpected token ')' in expression or statement.",")","Unexpected Error. Please check [Trouble Shotting for Unexpected Errors in Example Issues](***/blob/main/documentation/Debugging-StaticAnalysis-Errors.md#Troubleshotting-Example-Issues) for more details."
  "Az.NetworkCloud","Update-AzNetworkCloudCluster","2","13","UnexpectedToken","5200","1","Unexpected token '}' in expression or statement.","}","Unexpected Error. Please check [Trouble Shotting for Unexpected Errors in Example Issues](***/blob/main/documentation/Debugging-StaticAnalysis-Errors.md#Troubleshotting-Example-Issues) for more details."
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","11","Invalid_Parameter_Name","5011","1","New-AzNetworkCloudCluster -AnalyticOutputSettingAnalyticsWorkspaceId is not a valid parameter name.","-AnalyticOutputSettingAnalyticsWorkspaceId","Check validity of the parameter -AnalyticOutputSettingAnalyticsWorkspaceId."
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","11","Invalid_Parameter_Name","5011","1","New-AzNetworkCloudCluster -AnalyticsOutputSettingsAssociatedIdentityType is not a valid parameter name.","-AnalyticsOutputSettingsAssociatedIdentityType","Check validity of the parameter -AnalyticsOutputSettingsAssociatedIdentityType."
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","11","Invalid_Parameter_Name","5011","1","New-AzNetworkCloudCluster -AnalyticsOutputSettingsAssociatedIdentityUserAssignedIdentityResourceId is not a valid parameter name.","-AnalyticsOutputSettingsAssociatedIdentityUserAssignedIdentityResourceId","Check validity of the parameter -AnalyticsOutputSettingsAssociatedIdentityUserAssignedIdentityResourceId."
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","11","Invalid_Parameter_Name","5011","1","New-AzNetworkCloudCluster -CommandOutputSettingsAssociatedIdentityType is not a valid parameter name.","-CommandOutputSettingsAssociatedIdentityType","Check validity of the parameter -CommandOutputSettingsAssociatedIdentityType."
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","11","Invalid_Parameter_Name","5011","1","New-AzNetworkCloudCluster -CommandOutputSettingsAssociatedIdentityUserAssignedIdentityResourceId is not a valid parameter name.","-CommandOutputSettingsAssociatedIdentityUserAssignedIdentityResourceId","Check validity of the parameter -CommandOutputSettingsAssociatedIdentityUserAssignedIdentityResourceId."
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","11","Invalid_Parameter_Name","5011","1","New-AzNetworkCloudCluster -SecretArchiveSettingVaultUri is not a valid parameter name.","-SecretArchiveSettingVaultUri","Check validity of the parameter -SecretArchiveSettingVaultUri."
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","11","Invalid_Parameter_Name","5011","1","New-AzNetworkCloudCluster -SecretArchiveSettingsAssociatedIdentityType is not a valid parameter name.","-SecretArchiveSettingsAssociatedIdentityType","Check validity of the parameter -SecretArchiveSettingsAssociatedIdentityType."
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","11","Invalid_Parameter_Name","5011","1","New-AzNetworkCloudCluster -SecretArchiveSettingsAssociatedIdentityUserAssignedIdentityResourceId is not a valid parameter name.","-SecretArchiveSettingsAssociatedIdentityUserAssignedIdentityResourceId","Check validity of the parameter -SecretArchiveSettingsAssociatedIdentityUserAssignedIdentityResourceId."
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","11","Invalid_Parameter_Name","5011","1","New-AzNetworkCloudCluster -UpdateStrategyWaitTimeMinutes is not a valid parameter name.","-UpdateStrategyWaitTimeMinutes","Check validity of the parameter -UpdateStrategyWaitTimeMinutes."
  "Az.NetworkCloud","New-AzNetworkCloudCluster","2","11","Invalid_Parameter_Name","5011","1","New-AzNetworkCloudCluster -VulnerabilityScanningSettingContainerScan is not a valid parameter name.","-VulnerabilityScanningSettingContainerScan","Check validity of the parameter -VulnerabilityScanningSettingContainerScan."
  "Az.NetworkCloud","Update-AzNetworkCloudCluster","2","12","Invalid_Parameter_Name","5011","1","Update-AzNetworkCloudCluster -ClusterType is not a valid parameter name.","-ClusterType","Check validity of the parameter -ClusterType."
  "Az.NetworkCloud","Update-AzNetworkCloudCluster","2","12","Invalid_Parameter_Name","5011","1","Update-AzNetworkCloudCluster -ClusterVersion is not a valid parameter name.","-ClusterVersion","Check validity of the parameter -ClusterVersion."
  "Az.NetworkCloud","Update-AzNetworkCloudCluster","2","12","Invalid_Parameter_Name","5011","1","Update-AzNetworkCloudCluster -ExtendedLocationName is not a valid parameter name.","-ExtendedLocationName","Check validity of the parameter -ExtendedLocationName."

@priyamshet please refer to the error messages above to fix the examples in the help docs of the cmdlets above

msJinLei · 2025-05-20T08:26:27Z

...custom/autogen-model-cmdlets/New-AzNetworkCloudBgpServiceLoadBalancerConfigurationObject.ps1

 [CmdletBinding(PositionalBinding=$false)]
 Param(

 [Parameter(HelpMessage="The association of IP address pools to the communities and peers, allowing for announcement of IPs.")]
-[Microsoft.Azure.PowerShell.Cmdlets.NetworkCloud.Models.Api20240701.IBgpAdvertisement[]]
+[Microsoft.Azure.PowerShell.Cmdlets.NetworkCloud.Models.Api20250201.IBgpAdvertisement[]]


It is reported that the type is unable to find. Could you check again?

This property does exist in the swagger spec https://.com/Azure/azure-rest-api-specs/blob/1ca714a9d53e37f86b4dabb9dfb9365233fe9da0/specification/networkcloud/resource-manager/Microsoft.NetworkCloud/stable/2025-02-01/networkcloud.json#L8047
Should we be checking something else for this issue?

This should be updated with the latest changes - before this point the 20240701 module was still being generated instead of 20250201, which is why the type couldn't be found.

wyunchi-ms · 2025-05-21T04:23:40Z

src/NetworkCloud/NetworkCloud.Autorest/docs/New-AzNetworkCloudCluster.md

+}
+$securePassword = ConvertTo-SecureString "password" -asplaintext -force
+$identityUserAssignedIdentity = @{}
+$identityUserAssignedIdentity.Add(userAssignedIdentityResourceId, @{})


Suggested change
$identityUserAssignedIdentity.Add(userAssignedIdentityResourceId, @{})
$identityUserAssignedIdentity.Add($userAssignedIdentityResourceId, @{})

Made this change and also added dummy value for $identityUserAssignedIdentity

wyunchi-ms · 2025-05-21T04:24:24Z

src/NetworkCloud/NetworkCloud.Autorest/docs/Update-AzNetworkCloudCluster.md

+}
+$securePassword = ConvertTo-SecureString "password" -asplaintext -force
+$identityUserAssignedIdentity = @{}
+$identityUserAssignedIdentity.Add(userAssignedIdentityResourceId, @{})


Suggested change
$identityUserAssignedIdentity.Add(userAssignedIdentityResourceId, @{})
$identityUserAssignedIdentity.Add($userAssignedIdentityResourceId, @{})

Made this change and also added dummy value for $identityUserAssignedIdentity

/azp run

Azure Pipelines successfully started running 3 pipeline(s).

/azp run

Azure Pipelines successfully started running 3 pipeline(s).

/azp run

Azure Pipelines successfully started running 3 pipeline(s).

/azp run

Azure Pipelines successfully started running 3 pipeline(s).

/azp run

Commenter does not have sufficient privileges for PR 27724 in repo Azure/azure-powershell

/azp run

Azure Pipelines successfully started running 3 pipeline(s).

@vidai-msft

Hi @vidai-msft, could you help us understand why it seems the module for 2025-02-01 isn't being generated? From the pipeline artifacts I only see 2024-07-01, but the commit in our readme is correct for the 2025-02-01 API spec. I believe this is why the CI checks are failing.

/azp run

Azure Pipelines successfully started running 3 pipeline(s).

@vidai-msft

Hi @vidai-msft, could you help us understand why it seems the module for 2025-02-01 isn't being generated? From the pipeline artifacts I only see 2024-07-01, but the commit in our readme is correct for the 2025-02-01 API spec. I believe this is why the CI checks are failing.

I chatted in the teams channel with Yunchi - latest commit I made sure generate-info.json was included, hopefully that fixes this issue.

/azp run

Azure Pipelines successfully started running 3 pipeline(s).

…gnedIdentityResourceId

/azp run

Azure Pipelines successfully started running 3 pipeline(s).

/azp run

Azure Pipelines successfully started running 3 pipeline(s).

@annapankiewicz

@annapankiewicz There are 2 issues detected in the Static Analysis stage.
For the signature issue, please feel free to suppress it.
"Module","ClassName","Target","Severity","ProblemId","Description","Remediation"
"Az.NetworkCloud","New-AzNetworkCloudCluster","New-AzNetworkCloudCluster","1","8410","Parameter UpdateStrategyWaitTimeMinutes of cmdlet New-AzNetworkCloudCluster does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."
"Az.NetworkCloud","Update-AzNetworkCloudCluster","Update-AzNetworkCloudCluster","1","8410","Parameter UpdateStrategyWaitTimeMinutes of cmdlet Update-AzNetworkCloudCluster does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."

For the breaking change issue, we will reply in the Teams channel.

/azp run

Azure Pipelines successfully started running 3 pipeline(s).

mfoster58 added 2 commits May 9, 2025 14:05

adding new Powershell tests & recordings for 2025-02-01 API

ac9152f

updating changelog

37a5119

priyamshet reviewed May 9, 2025
View reviewed changes

mfoster58 marked this pull request as ready for review May 9, 2025 22:48

mfoster58 and others added 2 commits May 12, 2025 15:43

bumping version in changelog

017a2cd

Update ChangeLog.md

9f4d895

wyunchi-ms added the needs-revision label May 13, 2025

mfoster58 added 2 commits May 14, 2025 17:22

fixing bug in example files

369fbd9

Merge branch 'networkcloud-2025-02-01' of https://.com/mfoster5…

670e466
…8/azure-powershell into networkcloud-2025-02-01

msJinLei suggested changes May 20, 2025
View reviewed changes

wyunchi-ms reviewed May 21, 2025
View reviewed changes

fixing examples

3417cc2

regen help docs

0e0abd9

remove invalid parameters

57c1b29

adding back in new parameters

5fa0c44

Update Update-KubernetesClusterFeature example

0253038

Update module and make sure generate-info.json is included

f8edce1

annapankiewicz requested a review from msJinLei June 9, 2025 18:33

Anna Pankiewicz added 3 commits June 10, 2025 19:00

Resolve parameter issues in examples

6b7e3a8

Remove AssemblyInfo per FileChangeIssue anaylsis results

8211f7d

Add aliases for AssociatedIdentityType and AssociatedIdentityUserAssi…

bba81c1
…gnedIdentityResourceId

Update tests and example for updated parameter aliases

f18f07e

annapankiewicz mentioned this pull request Jun 11, 2025
Generate module for NetworkCloud 2025-02-01 API - testing generation issue #27938
Closed
6 tasks

Anna Pankiewicz added 2 commits June 17, 2025 18:08

Use property rename for Cluster CommandOutputSettings properties

e3e930b

Suppress signature issues as directed

5e9ebc7

	$identityUserAssignedIdentity.Add(userAssignedIdentityResourceId, @{})
	$identityUserAssignedIdentity.Add($userAssignedIdentityResourceId, @{})

Uh oh!

Conversation

Description

Mandatory Checklist

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!