Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the ManagedServices module to autorest v4 and updates associated cmdlets and documentation. The changes standardize model type references from the preview namespace to the general namespace, update sample examples and URLs, and adjust documentation to reflect new cmdlet variants.
- Updated generate-info.json GUID
- Revised documentation and sample examples to align with autorest v4 changes (e.g., model types and cmdlet syntax)
- Adjusted custom cmdlet scripts with updated attributes and output types
Reviewed Changes
Copilot reviewed 37 out of 37 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/ManagedServices/ManagedServices.Autorest/generate-info.json | Updated the generate_Id value |
src/ManagedServices/ManagedServices.Autorest/examples/Update-AzManagedServicesDefinition.md | Updated sample example for updating a registration definition |
src/ManagedServices/ManagedServices.Autorest/docs/Update-AzManagedServicesDefinition.md | Added new documentation for the Update cmdlet |
src/ManagedServices/ManagedServices.Autorest/docs/Remove-AzManagedServicesDefinition.md | Minor documentation fixes |
src/ManagedServices/ManagedServices.Autorest/docs/Remove-AzManagedServicesAssignment.md | Minor documentation fixes |
src/ManagedServices/ManagedServices.Autorest/docs/New-AzManagedServicesEligibleAuthorizationObject.md | Documentation updates and parameter type change for multi-factor auth provider |
src/ManagedServices/ManagedServices.Autorest/docs/New-AzManagedServicesEligibleApproverObject.md | Updated URL and model type reference |
src/ManagedServices/ManagedServices.Autorest/docs/New-AzManagedServicesDefinition.md | Updated documentation with new cmdlet variants and updated output types |
src/ManagedServices/ManagedServices.Autorest/docs/New-AzManagedServicesAuthorizationObject.md | Adjusted model type references |
src/ManagedServices/ManagedServices.Autorest/docs/New-AzManagedServicesAssignment.md | Added new documentation for assignment cmdlet with Json variants |
src/ManagedServices/ManagedServices.Autorest/docs/Get-AzManagedServicesMarketplaceDefinition.md | Updated output type reference |
src/ManagedServices/ManagedServices.Autorest/docs/Get-AzManagedServicesDefinition.md | Updated output type reference |
src/ManagedServices/ManagedServices.Autorest/docs/Get-AzManagedServicesAssignment.md | Updated output type reference |
src/ManagedServices/ManagedServices.Autorest/docs/Az.ManagedServices.md | Updated module metadata and cmdlet descriptions |
src/ManagedServices/ManagedServices.Autorest/custom/autogen-model-cmdlets/New-AzManagedServicesEligibleApproverObject.ps1 | Updated model type and documentation link |
src/ManagedServices/ManagedServices.Autorest/custom/autogen-model-cmdlets/New-AzManagedServicesAuthorizationObject.ps1 | Updated model type and documentation link |
src/ManagedServices/ManagedServices.Autorest/custom/New-AzManagedServicesEligibleAuthorizationObject.ps1 | Updated header, model reference, and parameter attribute for multi-factor auth provider |
src/ManagedServices/ManagedServices.Autorest/custom/Get-AzManagedServicesMarketplaceDefinition.ps1 | Updated output type reference |
src/ManagedServices/ManagedServices.Autorest/README.md | Updated directives, regex, and model-cmdlet mapping |
src/ManagedServices/ManagedServices.Autorest/Properties/AssemblyInfo.cs | Updated assembly GUID and version information |
Comments suppressed due to low confidence (1)
src/ManagedServices/ManagedServices.Autorest/docs/New-AzManagedServicesEligibleAuthorizationObject.md:97
- Ensure that changing the parameter type for 'JustInTimeAccessPolicyMultiFactorAuthProvider' from a dedicated enum ('MultiFactorAuthProvider') to 'System.String' is intentional and that appropriate validation is implemented where this parameter is used.
Type: System.String
$permantAuth = New-AzManagedServicesAuthorizationObject -PrincipalId "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" -RoleDefinitionId "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" -PrincipalIdDisplayName "Test user" -DelegatedRoleDefinitionId "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx","xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" | ||
Update-AzManagedServicesDefinition -Name xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx -RegistrationDefinitionName "Test definition" -ManagedByTenantId "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" -Authorization $permantAuth -Description "Test definition desc" -Scope "/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo detected in the variable name '$permantAuth'. Consider renaming it to '$permanentAuth' to improve clarity.
$permantAuth = New-AzManagedServicesAuthorizationObject -PrincipalId "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" -RoleDefinitionId "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" -PrincipalIdDisplayName "Test user" -DelegatedRoleDefinitionId "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx","xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" | |
Update-AzManagedServicesDefinition -Name xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx -RegistrationDefinitionName "Test definition" -ManagedByTenantId "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" -Authorization $permantAuth -Description "Test definition desc" -Scope "/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" | |
$permanentAuth = New-AzManagedServicesAuthorizationObject -PrincipalId "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" -RoleDefinitionId "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" -PrincipalIdDisplayName "Test user" -DelegatedRoleDefinitionId "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx","xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" | |
Update-AzManagedServicesDefinition -Name xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx -RegistrationDefinitionName "Test definition" -ManagedByTenantId "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" -Authorization $permanentAuth -Description "Test definition desc" -Scope "/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" |
Copilot uses AI. Check for mistakes.
To the author of the pull request, |
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.