Description

Mandatory Checklist

• Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)

  • General release
  • Public preview
  • Private preview
  • Engineering build
  • No need for a release

• Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

• SHOULD update ChangeLog.md file(s) appropriately
  • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
  • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
• SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
• SHOULD have proper test coverage for changes in pull request.
• SHOULD NOT adjust version of module manually in pull request

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Pull Request Overview

This PR updates the version controller script to use Find-PSResource against an Azure Artifacts feed (or fallback repository) instead of Find-Module from PSGallery.

• Introduces conditional logic to detect DEFAULT_PS_REPOSITORY_URL and use credentials for Azure Artifacts
• Switches Find-Module calls in both Bump-AzVersion and Update-AzPreviewChangelog to Find-PSResource
• Adds version filtering and sorting for LTS releases

[Copilot]

Inside the LTS branch, the command references 'AzPreview' instead of 'Az', which breaks the original LTS logic for bumping the stable Az module. It should use -Name Az to fetch the correct module.

Suggested change

	$galleryAz = Find-PSResource -Name AzPreview -Repository $Env:DEFAULT_PS_REPOSITORY_NAME -Credential $credentialsObject -TrustRepository
	}
	else {
	$galleryAz = Find-PSResource -Name AzPreview -Repository $GalleryName -Version *
	$galleryAz = Find-PSResource -Name Az -Repository $Env:DEFAULT_PS_REPOSITORY_NAME -Credential $credentialsObject -TrustRepository
	}
	else {
	$galleryAz = Find-PSResource -Name Az -Repository $GalleryName -Version *

[Copilot]

[nitpick] The repository-detection and credential setup blocks are duplicated in both release branches. Consider extracting this into a helper function to reduce duplication and simplify future updates.

Suggested change

	if (Test-Path Env:\DEFAULT_PS_REPOSITORY_URL) {
	Write-Host "Using DEFAULT_PS_REPOSITORY_NAME: $Env:DEFAULT_PS_REPOSITORY_NAME"
	$AccessTokenSecureString = $env:SYSTEM_ACCESS_TOKEN | ConvertTo-SecureString -AsPlainText -Force
	$credentialsObject = [pscredential]::new("ONEBRANCH_TOKEN", $AccessTokenSecureString)
	$galleryAz = Find-PSResource -Name AzPreview -Repository $Env:DEFAULT_PS_REPOSITORY_NAME -Credential $credentialsObject -TrustRepository
	}
	else {
	$galleryAz = Find-PSResource -Name AzPreview -Repository $GalleryName -Version *
	}
	$galleryAz = $galleryAz | Where-Object { ([System.Version]($_.Version)).Major%2 -eq 0 } | Sort-Object {[System.Version]$_.Version} -Descending
	}
	else
	{
	if (Test-Path Env:\DEFAULT_PS_REPOSITORY_URL) {
	Write-Host "Using DEFAULT_PS_REPOSITORY_NAME: $Env:DEFAULT_PS_REPOSITORY_NAME"
	$AccessTokenSecureString = $env:SYSTEM_ACCESS_TOKEN | ConvertTo-SecureString -AsPlainText -Force
	$credentialsObject = [pscredential]::new("ONEBRANCH_TOKEN", $AccessTokenSecureString)
	$galleryAz = Find-PSResource -Name AzPreview -Repository $Env:DEFAULT_PS_REPOSITORY_NAME -Credential $credentialsObject -TrustRepository
	}
	else {
	$galleryAz = Find-PSResource -Name AzPreview -Repository $GalleryName
	}
	$galleryAz = Get-GalleryAz -ReleaseType "LTS" -GalleryName $GalleryName
	$galleryAz = $galleryAz | Where-Object { ([System.Version]($_.Version)).Major%2 -eq 0 } | Sort-Object {[System.Version]$_.Version} -Descending
	}
	else
	$galleryAz = Get-GalleryAz -ReleaseType "STS" -GalleryName $GalleryName

[Copilot]

[nitpick] Using Test-Path to check for an environment variable can be misleading—consider directly testing $env:DEFAULT_PS_REPOSITORY_URL (e.g. if (-not [string]::IsNullOrEmpty($env:DEFAULT_PS_REPOSITORY_URL))) to ensure the variable is both present and nonempty.

Suggested change

	if (Test-Path Env:\DEFAULT_PS_REPOSITORY_URL) {
	if (-not [string]::IsNullOrEmpty($env:DEFAULT_PS_REPOSITORY_URL)) {

[Copilot]

[nitpick] Consider using Write-Verbose instead of Write-Host for informational messages so that consumers can control verbosity with the -Verbose switch.