Conversation

andyleejordan

We'll still see the same error in the log, but as a warning and not as an exception bubbled up over LSP that causes some clients, like Kate, to crash. We can't do anything about PowerShell's completion failing.

Fixes #1926.

@andyleejordanandyleejordan requested a review from a team October 21, 2022 20:55
@ghost ghost added Area-IntelliSense Issue-BugA bug to squash.labels Oct 21, 2022
@andyleejordanandyleejordan force-pushed the andschwa/handle-failed-completions branch 5 times, most recently from ade9d58 to 3f22ad4 Compare October 21, 2022 22:45
@andyleejordanandyleejordan enabled auto-merge (squash) October 21, 2022 22:46
SeeminglyScience
SeeminglyScience approved these changes Oct 24, 2022
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion

@andyleejordanandyleejordan force-pushed the andschwa/handle-failed-completions branch 2 times, most recently from 620e2f4 to 0948131 Compare October 24, 2022 21:38
@andyleejordan
Catch exceptions within completion handler
fb62522
We'll still see the same error in the log, but as a warning and not as
an exception bubbled up over LSP that causes some clients, like Kate, to
crash. We can't do anything about PowerShell's completion failing.
@andyleejordanandyleejordan force-pushed the andschwa/handle-failed-completions branch from 0948131 to fb62522 Compare October 24, 2022 22:49
@andyleejordanandyleejordan merged commit 5df82eb into main Oct 24, 2022
@andyleejordanandyleejordan deleted the andschwa/handle-failed-completions branch October 24, 2022 23:13
Sign up for free to join this conversation on . Already have an account? Sign in to comment

@SeeminglyScience SeeminglyScience SeeminglyScience approved these changes

No one assigned
Area-IntelliSense Issue-BugA bug to squash.
None yet
No milestone

Successfully merging this pull request may close these issues.

Null reference exceptions when trying to complete variable names