Conversation

andyleejordan

So the client can skip updates for daily and s. Also clean up a little more, the commit ID was not actually being used in the rest of the codebase, and the DisplayVersion was dumb.

Also fix a bug that luckily didn't make it into the release where the Windows PowerShell version was sending its full self, i.e. 5.1.22621.436 which cannot be cast to a SemVer.

Required for PowerShell/vscode-powershell#4306.

@andyleejordanandyleejordan added Issue-EnhancementA feature request (enhancement).Area-Startup labels Dec 6, 2022
@andyleejordanandyleejordan requested a review from a team December 6, 2022 01:57
@andyleejordanandyleejordan force-pushed the andschwa/improve-version-handler branch from 4ccbb33 to 0899ed0 Compare December 6, 2022 02:13
So the client can skip updates for daily and s. Also clean up a
little more, the commit ID was not actually being used in the rest of
the codebase, and the `DisplayVersion` was dumb.
@andyleejordanandyleejordan force-pushed the andschwa/improve-version-handler branch 2 times, most recently from 966ee67 to a36481a Compare December 6, 2022 17:12

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordanandyleejordan merged commit 551cf8b into main Dec 6, 2022
@andyleejordanandyleejordan deleted the andschwa/improve-version-handler branch December 6, 2022 21:43
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Area-Startup Issue-EnhancementA feature request (enhancement).
None yet

Successfully merging this pull request may close these issues.