Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
src/PowerShellEditorServices/Services/DebugAdapter/Debugging/VariableDetails.cs Outdated Show resolved Hide resolved
Uh oh!
There was an error while loading. Please reload this page.
c53be4f to 817a3f6 Compare 817a3f6 to 08d2efc Compare d751d6e to 0ef094e Compare @JustinGrote I accidentally implemented the same idea you had in #1688 to fix another bug, so I borrowed your test. Can you pull this branch and give it a whack, see how it does? Things seem good to me. |
e8708a7 to 7b48683 Compare So that expansions of embedded PowerShell code succeed.
1e24ba0 to 36af0ee Compare Which fixes our test that gets the properties of a process object, since the value for `ExitCode` fails (as the process hasn't ended), we now handle that a bit more gracefully and can get all 130 properties. This also seemed to fix the overall bug where lots of expected properties failed to show up. While investigating, I also found many properties duplicated, seemingly due to being retrieved both off the PSObject and off the .NET object, so now when we do the latter we check (by name) that it hasn't already been added.
This now works fine since the expansion takes place on the pipeline thread.
So that it doesn't deadlock with the pipeline thread.
36af0ee to f6b1ffa Compare SeeminglyScience approved these changes Dec 20, 2022
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This resolves PowerShell/vscode-powershell#4174, PowerShell/vscode-powershell#4314, #1863 and #1686.