Conversation

andyleejordan

@andyleejordanandyleejordan requested a review from a team May 22, 2023 23:21
@andyleejordan

This should do the trick @JustinGrote!

@andyleejordanandyleejordan enabled auto-merge (squash) May 23, 2023 00:05
@andyleejordanandyleejordan force-pushed the andschwa/ignore-cancellation branch from f66089a to bd119b3 Compare May 23, 2023 00:09
@JustinGrote

LGTM, my testing shows it suppressed. Thanks!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordanandyleejordan merged commit c43c4a9 into main May 23, 2023
@andyleejordanandyleejordan deleted the andschwa/ignore-cancellation branch May 23, 2023 20:37
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Area-LoggingA bug to squash.
Status: Done

Successfully merging this pull request may close these issues.

Handle GetCompletionsAsync cancellation better