Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Tested that last commit with a temporary multi-root workspace: |
7e13faa to 056a4d5 Compare SeeminglyScience requested changes Aug 22, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Receive a `EditorOperationResponse` (not yet otherwise used). Delete dead code. Add optional `content` parameter to `NewFile`. Expose `CloseFile` and `SaveFile`. Fix an outdated warning message.
Since `Path` now refers to initial working directory.
| public void NewFile() => editorOperations.NewFileAsync().Wait(); | ||
| /// <param name="content">The content to place in the new file.</param> | ||
| public void NewFile(string content) => editorOperations.NewFileAsync(content).Wait(); | ||
| public void NewFile(string content = "") => editorOperations.NewFileAsync(content).Wait(); |
There was a problem hiding this comment.
Suggested change
| public void NewFile(string content = "") => editorOperations.NewFileAsync(content).Wait(); |
think the previous suggestion bugged out (or I did it wrong)
0849ad9 to 0d30182 Compare | @@ -123,15 +121,15 @@ public async Task SetSelectionAsync(BufferRange selectionRange) | |||
| clientContext.CurrentFileLanguage); | |||
| } | |||
| public async Task NewFileAsync() | |||
| public async Task NewFileAsync(string content = "") | |||
There was a problem hiding this comment.
Suggested change
| public async Task NewFileAsync(string content = "") | |
| public async Task NewFileAsync() => NewFileAsync(string.Empty); | |
| public async Task NewFileAsync(string content) |
0d30182 to 6805767 Compare So as to now add a binary breaking change. Co-authored-by: Patrick Meinecke <[email protected]>
6805767 to f6245f4 Compare SeeminglyScience approved these changes Aug 22, 2023
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Receive a
EditorOperationResponse(not yet otherwise used). Delete dead code. Add optionalcontentparameter toNewFile. ExposeCloseFileandSaveFile. Fix an outdated warning message.Part of PowerShell/vscode-powershell#4703 so I could test it.