Conversation

andyleejordan

So we're actually using TypeScript properly with type checking. Resolves #3561.

@andyleejordanandyleejordan added Issue-EnhancementA feature request (enhancement).Area-Engine labels Oct 12, 2022
@andyleejordanandyleejordan marked this pull request as ready for review October 15, 2022 00:12
@andyleejordanandyleejordan requested a review from a team October 15, 2022 00:12
@andyleejordanandyleejordan requested a review from a team as a code owner October 15, 2022 00:12
@andyleejordan

Hey @SeeminglyScience I did it! I hope. There was...some refactoring involved.

SeeminglyScience
SeeminglyScience approved these changes Oct 17, 2022
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordanandyleejordan force-pushed the andschwa/strict branch 3 times, most recently from 44437e4 to b04a4d1 Compare October 17, 2022 18:55
@andyleejordanandyleejordan merged commit c7adbdd into main Oct 17, 2022
@andyleejordanandyleejordan deleted the andschwa/strict branch October 17, 2022 20:07
Sign up for free to join this conversation on . Already have an account? Sign in to comment

@SeeminglyScience SeeminglyScience SeeminglyScience approved these changes

No one assigned
Area-Engine Issue-EnhancementA feature request (enhancement).
None yet
No milestone

Successfully merging this pull request may close these issues.

Enable TypeScript compiler's strict mode