Conversation

fflaten

PR Summary

Fixes dotnetDebuggerConfigName-option in launch config when using new attachDotnetDebugger feature introduced in #3903. Always threw config not found-error when dotnetDebuggerConfigName was set.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • [NA] PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@fflatenfflaten requested a review from a team April 13, 2023 20:50
@fflaten

/cc @JustinGrote Not sure how to add tests for this, but feel free to commit if you know. 🙂

@JustinGrote

Thanks! I'll take it from here!

@JustinGroteJustinGrote self-assigned this Apr 13, 2023
@JustinGroteJustinGrote enabled auto-merge (squash) April 14, 2023 16:18
@JustinGrote

@andschwa test added, ready for review. Thanks again @fflaten for the catch!

@andyleejordanandyleejordan changed the title Fix attachDotnetDebugger with custom dotnet config Fix attachDotnetDebugger with custom dotnet config Apr 14, 2023
@andyleejordanandyleejordan changed the title Fix attachDotnetDebugger with custom dotnet config Fix attachDotnetDebugger with custom config Apr 14, 2023
@JustinGroteJustinGrote merged commit 4d71946 into PowerShell:main Apr 14, 2023
@fflatenfflaten deleted the attach-customdotnetconfig branch April 14, 2023 18:05
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Area-Debugging Issue-BugA bug to squash.
Status: Done

Successfully merging this pull request may close these issues.