Merged

Bump ESLint packages to v6 #4667

Show file tree
Hide file tree
Changes from all commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
921ca0a
Bump ESLint packages to v6
andyleejordanJul 17, 2023
152b2d9
Updated ESLint rules configuration and run `--fix`
andyleejordanJul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Failed to load files.
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,19 +5,16 @@
},
"extends": [
"eslint:recommended",
"plugin:@typescript-eslint/recommended",
"plugin:@typescript-eslint/recommended-requiring-type-checking",
"plugin:@typescript-eslint/strict"
"plugin:@typescript-eslint/stylistic-type-checked",
"plugin:@typescript-eslint/strict-type-checked"
],
"overrides": [],
"parser": "@typescript-eslint/parser",
"parserOptions": {
"ecmaVersion": "latest",
"sourceType": "module",
"tsconfigRootDir": ".",
"project": [
"./tsconfig.json"
]
"project": true
},
"plugins": [
"@typescript-eslint",
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -567,7 +567,7 @@ export class PickPSHostProcessFeature extends LanguageClientConsumer {
(resolve, reject) => {
this.getLanguageClientResolve = resolve;

window
void window
.showQuickPick(
["Cancel"],
{ placeHolder: "Attach to PowerShell host process: Please wait, starting PowerShell..." },
Expand DownExpand Up@@ -692,7 +692,7 @@ export class PickRunspaceFeature extends LanguageClientConsumer {
(resolve, reject) => {
this.getLanguageClientResolve = resolve;

window
void window
.showQuickPick(
["Cancel"],
{ placeHolder: "Attach to PowerShell host process: Please wait, starting PowerShell..." },
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -203,7 +203,7 @@ export class ExtensionCommandsFeature extends LanguageClientConsumer {
this.handlers = [
this.languageClient.onNotification(
ExtensionCommandAddedNotificationType,
(command) => this.addExtensionCommand(command)),
(command) => { this.addExtensionCommand(command); }),

this.languageClient.onRequest(
GetEditorContextRequestType,
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -34,8 +34,8 @@ export class GetCommandsFeature extends LanguageClientConsumer {
super();
this.commands = [
vscode.commands.registerCommand("PowerShell.RefreshCommandsExplorer",
async () => await this.CommandExplorerRefresh()),
vscode.commands.registerCommand("PowerShell.InsertCommand", async (item) => await this.InsertCommand(item))
async () => { await this.CommandExplorerRefresh(); }),
vscode.commands.registerCommand("PowerShell.InsertCommand", async (item) => { await this.InsertCommand(item); })
];
this.commandsExplorerProvider = new CommandsExplorerProvider();

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -69,7 +69,7 @@ export class RemoteFilesFeature extends LanguageClientConsumer {

await vscode.window.showTextDocument(doc);
await vscode.commands.executeCommand("workbench.action.closeActiveEditor");
return await innerCloseFiles();
await innerCloseFiles();
}

void innerCloseFiles();
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -156,7 +156,8 @@ export class UpdatePowerShell {
try {
const tag = await this.maybeGetNewRelease();
if (tag) {
return await this.promptToUpdate(tag);
await this.promptToUpdate(tag);
return;
}
} catch (err) {
// Best effort. This probably failed to fetch the data from .
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -114,7 +114,7 @@ export class PowerShellProcess {
// all terminals and the event itself checks if it's our terminal). This
// subscription should happen before we create the terminal so if it
// fails immediately, the event fires.
this.consoleCloseSubscription = vscode.window.onDidCloseTerminal((terminal) => this.onTerminalClose(terminal));
this.consoleCloseSubscription = vscode.window.onDidCloseTerminal((terminal) => { this.onTerminalClose(terminal); });
this.consoleTerminal = vscode.window.createTerminal(terminalOptions);
this.pid = await this.getPid();
this.logger.write(`PowerShell process started with PID: ${this.pid}`);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -489,8 +489,8 @@ describe("DebugSessionFeature E2E", () => {

const debugStarted = await debug.startDebugging(undefined, launchScriptConfig);
assert.ok(debugStarted);
const debugStopped = await debug.stopDebugging(undefined);
assert.ok(debugStopped);

await debug.stopDebugging(undefined);

assert.ok(startDebugging.calledTwice);
assert.ok(startDebugging.calledWith(undefined, launchScriptConfig));
Expand DownExpand Up@@ -531,11 +531,11 @@ describe("DebugSessionFeature E2E", () => {
const dotnetDebugSession = await dotnetDebugSessionActive;
console.log(debug.activeDebugSession);
console.log(debug.breakpoints);
const debugStopped = await debug.stopDebugging(undefined);

await debug.stopDebugging(undefined);

assert.ok(debugStarted);
assert.ok(dotnetDebugSession);
assert.ok(debugStopped);
});
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,7 +68,8 @@ function runTestsInner(testsRoot: string): Promise<void> {
throw new Error(`${failures} tests failed.`);
} else {
console.log("\n\n=====\nTest Runner STOP\n=====");
return c();
c();
return;
}
});
} catch (err) {
Expand Down