PR Summary

The vscode stopDebugging API when used with the dotnet debugger would kill the powershell process if it was in attach mode, so we use a customRequest DAP message to disconnect the dotnet debugger since there is no vscode direct API for disconnecting the debug session.

Fixes #4702

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

• PR has a meaningful title
• Summarized changes
• PR has tests
• This PR is ready to merge and is not work in progress
  • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@andyleejordan should we bring in https://www.npmjs.com/package/@vscode/debugprotocol as a dependency for strong typing of the custom disconnect request? esbuild should tree shake it and not increase the overall file size much.

@andyleejordan should we bring in https://www.npmjs.com/package/@vscode/debugprotocol as a dependency for strong typing of the custom disconnect request? esbuild should tree shake it and not increase the overall file size much.

Yes!

Yes!

Since the only thing we need to bring in is an interface, it should be fine as a dev dependency

I made a slight change to use the full request type as the template, because hovering it will provide full intellisense over what this request does.

Just me being annoying with spacing and wishing ESLint were better at things like that.

Just me being annoying with spacing and wishing ESLint were better at things like that.

@andyleejordan Prettier is focused on whitespace stuff and interoperates with ESLint, we can explore adding it to the toolchain.

Test Failure on 5.1 doesn't appear to be related to this PR, so I'm going to merge it.