Conversation

JustinGrote

PR Summary

The package.json info is now available in the extension context, this avoids a round trip. Note there is no validation on the import of the information (there wasn't before either), but it's very unlikely to surface a null or undefined, or have that affect operation of the extension (famous last words).

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • [NA] PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@JustinGroteJustinGrote self-assigned this Oct 29, 2024
@JustinGroteJustinGrote changed the title Replace require with extension handling Refactor: Replace package.json requires with extension context info Oct 29, 2024
@JustinGroteJustinGrote marked this pull request as ready for review October 29, 2024 17:34
@JustinGroteJustinGrote added this pull request to the merge queue Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, thanks!

Merged via the queue into main with commit 64f32d3 Oct 29, 2024
7 checks passed
@JustinGroteJustinGrote deleted the refactor/packageJsonRefs branch October 29, 2024 18:57
@JustinGrote

Quick note that this API is also available in 1.82 which is what Azure Data Studio is on so that should be fine but I haven't directly tested it.
https://.com/microsoft/vscode/blob/release/1.82/src/vscode-dts/vscode.d.ts#L7077

@andyleejordan

@JustinGrote we no longer have to support ADS and I bumped our engine to 1.94!

@andyleejordanandyleejordan added the Issue-EnhancementA feature request (enhancement).label Oct 30, 2024
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Area-Startup Issue-EnhancementA feature request (enhancement).
None yet

Successfully merging this pull request may close these issues.