Conversation

JustinGrote

PR Summary

Changes logging glyph from◀️to ⬅️ which has better ZWF formatting in logs

@JustinGroteJustinGrote self-assigned this Oct 31, 2024
@JustinGroteJustinGrote added Bug:Bugs reproducing only in the extension.Area-Logging labels Oct 31, 2024
@JustinGroteJustinGrote added this pull request to the merge queue Oct 31, 2024
@andyleejordanandyleejordan added the Issue-BugA bug to squash.label Oct 31, 2024
@andyleejordanandyleejordan removed this pull request from the merge queue due to a manual request Oct 31, 2024
@andyleejordan

@JustinGrote are you sure you have the right right-arrow? I'd expect to see ➡️ since I'm seeing ⬅️ but I'm seeing ➡️...which I just copy-pasted and it shows correctly here. isn't rendering it well in the file diff 😭

@andyleejordan
Screenshot 2024-10-31 at 10 18 46 AM

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me re-verify but it looked good in code

@JustinGrote

Looks fine to me in ...
image

And in Code:
image

@JustinGrote

Files changed tab looks fine to me too in on the PR:
image

Are you on a Mac or something? Also using edge browser here.

@JustinGroteJustinGrote added this pull request to the merge queue Oct 31, 2024
@JustinGrote

Checking the glyph codepoints they look good to me, so I'm going to go ahead and merge queue it. If we find something's wrong with the code points we can fix-forward, but again since this is just the DAP trace log and not user-facing it's not a big deal either way.

Merged via the queue into main with commit dbae6ab Oct 31, 2024
7 checks passed
@JustinGroteJustinGrote deleted the fix/changeDAPGlyph branch October 31, 2024 17:49
@andyleejordan

Files changed tab looks fine to me too in on the PR: image

Are you on a Mac or something? Also using edge browser here.

Yeah, in Edge on a Mac. It's weird! No worries though.

Sign up for free to join this conversation on . Already have an account? Sign in to comment
Area-Logging Bug:Bugs reproducing only in the extension.Issue-BugA bug to squash.
None yet

Successfully merging this pull request may close these issues.