Conversation

andyleejordan

Since we added logic which searches for possible intended permutations of the given additional PowerShell path, we needed to make the warning show only if none of the permutations were found. This was accomplished by suppressing it in the first iterator and then yielding it again after the permutations were exhausted with the warning unsuppressed.

@JustinGrote this bug just really annoyed me...I'm surprised no one reported it yet.

Since we added logic which searches for possible intended permutations
of the given additional PowerShell path, we needed to make the warning
show only if none of the permutations were found. This was accomplished
by suppressing it in the first iterator and then yielding it again after
the permutations were exhausted with the warning unsuppressed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests pass on my machine.

@andyleejordanandyleejordan merged commit 7a42c84 into main Nov 21, 2024
7 checks passed
@andyleejordanandyleejordan deleted the fix-warning branch November 21, 2024 00:24
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Issue-BugA bug to squash.
Status: Done

Successfully merging this pull request may close these issues.