Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The builds that are failing have OTA partitions, so after #10346 I think they might all fit. The size difference on the Feather S3 build is about 50kB larger for the full bundle. This is not terrible and maybe we should just use the full cert bundle, instead of trying to tune which certificates are most common. adafruit/nina-fw#70 (in progress), which revamps NINA-FW extensively, also uses the full bundle and it fits. |
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is an experiment to see how big the builds are when we use the full Mozilla root certificate bundle, which can be generated by the ESP-IDF build process.
Tested this locally with the usual Guide wifi test script on Feather ESP32-S3 4/2 (whose ota_0 partition was just doubled in size). Its https fetches to various places are working.