Conversation

nontangent

Checklist

Description

Fix #3077 and add unit tests.

Code sample

No API changes.

@google-cla

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@nontangentnontangent marked this pull request as ready for review November 4, 2022 06:04
@nontangent

I've just signed CLA.

@davideastdavideast self-requested a review June 23, 2023 15:10
@davideastdavideast self-assigned this Jun 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nontangent Thank you so much for this contribution and I apologize for how late it took us to get to it. I'll need to test through one a bit thoroughly myself so hang tight.

@arlopezg

I think this would fix #3309

Sign up for free to join this conversation on . Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Code in schematics/deploy/builder.ts is preventing the usage of any non-default firebaseProject and firebaseHostingSite values